From: Thibaut M. <tma...@no...> - 2003-09-24 21:23:29
|
Hi, On Wednesday 24 September 2003 15:11, R. Bernstein wrote: > tma...@no... writes: > > it is a part of the lib, look at xine_demux_flush_engine() in demux.c, > > it's used by the dvd input plugin (input_dvd.c). > > Okay, have done. Thanks! > > Anyone know why this comment at the top of xine_demux_flush_engine()? > > /* internal use only - called from demuxers on seek/stop .. > > Neither input_dvd.c, the VCD input plugin, nor the CDDA plugin are > demuxers in the xine sense. And I'm not sure what's so "internal" if > a dynamically loadable input plugin is using. Because IMHO calling this function from an input plugin is a hack, but at least this function does the right thing to flush the engine, so if you really need to flush the engine, you should call this function. > > it's not really a new function, initial commit: Fri Jun 7 02:40:47 2002 > > UTC > > http://cvs.sourceforge.net/cgi-bin/viewcvs.cgi/xine/xine-lib/src/xine- > > engine/demux.c > > And was added to input_dvd.c that you mention about 6 months later... And ? What do yo mean, there was no way for you to find this function because it was not used by input_dvd.c ? > > about the flush stuff, update your xine-lib more often than once every > > two years ;-) > > Your math is a bit weird. Jun 7 2002 - Sept 24 2003 is less than one > and 1/3 years (which most people would round down in describing in > years) and less than a year when you consider when it was added to the > DVD plugin you mention. Clearly one has to update xine-lib more often > than this to catch the API changes which break plugins unless they are > updated. eh, there was no math, it was a joke, notice the ";-)", a bit ironic yes, but still a joke. > I update way more often than this: > http://xinehq.de/index.php/hackersguide which doesn't mention. ;-) right... > But at any rate, thanks for the information if not the snide > comment. Sorry, it's perhaps only me, but i was not very happy with this comment : "things that I believe should be in xine-lib but for reasons that have always been a mystery to me aren't. ". Don't you have cvs commit rights ? cheers, thibaut |