[xine-devel] Stack smash bug (fix included)

[Steve F. <cau...@ya...>]

Don't know if this has been fixed yet, but just in case.
In beta 12 of xine-lib, on line 702 of input_http.c:

    sprintf (buf, _("input_http: opening >/%s< on host >%s<"), 
	     this->filename, this->host);

buf is fixed-sized and no check is made to ensure that the final string fits. 
This will smash the stack on overly long MRLs.  Fix:

    snprintf (buf, 256, _("input_http: opening >/%s< on host >%s<"), 
	      this->filename, this->host);

n.b. I'm not subscribed to the list -- Cc: if necessary to respond
Thanks, by the way, for a really excellent piece of software.


______________________________________________________________________ 
Post your free ad now! http://personals.yahoo.ca