Re: [xine-devel] [PATCH] Descriptor leak with (file) input plugin

[Daniel Caujolle-B. <seg...@cl...>]

HI James,

James wrote:
> 
> I'd like to try and make the screensaver stuff a but more generic
> (aparrently in KDE you don't just kill the screensaver, you run a
> special command). My idea would be to have two config options:
> 
> screensaver.enable
> screensaver.disable
> 
> in those, the user can put whatever they want to enable/disable the
> screensaver.
> 
> At the appropriate time, Xine will run whatever's in those two config
> options. Does this sound a sane idea?
> 
> And what does xscreensaver-remote.c do? From reading the code it
> appears to go through all your open windows looking for XScreensaver,
> then run some "magic" to disable it. Ah, I just read the copyright
> line... JWZ wrote this code so it does contain lots of weird "magic"
> :-) Unless I'm mistaken, a lot of that code isn't needed by Xine (we
> don't really want to know how long the screensaver was last active, do
> we?).

	I don't see any "magic", xine-remote functions just try to find if 
xcreensaver is currently running. And this code is needed,  you have to 
think there are many many people who have installed a linux system, 
using it without any idea of what do what, they just want to click on an 
icon, and see the program doing hos job, dot. So, xscreensaver-remote is 
needed, and we can add a way to let the *users in knoledge* change the 
default behavior of xine-ui (by using such config stuff you describe).

Cheers.
-- 
73's de Daniel, F1RMB.

               -=- Daniel Caujolle-Bert -=- seg...@cl... -=-
                         -=- f1...@f1... (AMPR NET) -=-