#96 [1.19.2] Inconsistent mountpoint detection

closed
nobody
None
5
2009-10-19
2009-06-14
Anonymous
No

Xfe 1.19.2 indicates visually whether a folder is a regular folder, or a mount point. That does not always match reality. Here is what I really have, the output of the "mount" command:

rootfs on / type rootfs (rw)
/dev/root on / type reiserfs (rw,relatime)
proc on /proc type proc (rw,relatime)
sysfs on /sys type sysfs (rw,relatime)
tmpfs on /tmp type tmpfs (rw,relatime)
tmpfs on /dev type tmpfs (rw,relatime,mode=755)
devpts on /dev/pts type devpts (rw,relatime,gid=4,mode=620)
shm on /dev/shm type tmpfs (rw,relatime)
[ plus a couple /dev/loopX devices, all of them for squashfs file systems under /srv/bin/ ]

The attached screenshot shows xfe's idea of matters. It correctly identifies /sys and /tmp as mountpoints, but mistakes /dev and /proc for regular folders. See the icons in the screenshot (the text in the mouse-over popups give the same information).

Discussion

  • Nobody/Anonymous

    Again, looking at the source code revealed what is happening there. Here is a simple test case. It assumes that you do *not* have entries for /mnt, or for /dev/sda1, in your /etc/fstab.

    In a terminal, manually mount a USB stick on /mnt, e.g. "mount /dev/sda1 /mnt". Now look at your root folder with Xfe. Being a mount point, /mnt should have a device icon. However, Xfe uses a normal folder icon. Also, the mouse-over popup for /mnt says "Type: Folder." In contrast, a right-click on /mnt brings up a menu where "Unmount" can be selected -- so Xfe knows that /mnt is a mountpoint (not a regular folder). The "Properties" dialog from that menu also recognizes /mnt as "Mount point," "Mount type: Filesystem (/dev/sda1)." --

    Whereas Xfe does know that something is mounted on /mnt, it gives no visual indication. The reason behind that is Xfe sometimes uses /etc/fstab (where our /mnt is not listed, according to the assumption of this test case), and sometimes uses /etc/mtab, or /proc/mounts (where /mnt is listed after mounting the USB stick). /etc/fstab is used for the choice of icon, and for the type information in the automatic popup. /etc/mtab is used for the information in the right-click menu.

    The practical implication is that the user must keep in mind him-/herself where, exactly, s/he mounted the USB-stick -- which is one of those easy and boring tasks that we invented computers to do for us :-) An obvious improvement would come from using /etc/mtab (or /proc/mounts) for the choice of icon and popup, instead of using /etc/fstab.

    As a sidenote: the source code special-cases "proc" filesystems; they are always shown as regular folders. I wondered why that is considered necessary?

    And finally: if you followed the above testcase, then do not forget to unmount your USB stick before you remove it. Yes, it is still mounted on /mnt, even if you do not immediately see that in Xfe :-)

     
  • Roland Baudin

    Roland Baudin - 2009-10-19

    Fixed in released version 1.32.
    Thanks for the bug report.
    RB

     
  • Roland Baudin

    Roland Baudin - 2009-10-19
    • status: open --> closed
     

Log in to post a comment.