#314 Crash when manipulating bookmarks

[beastie]

1. A crash occurs when adding new bookmarks (Bookmarks > Add Bookmark). I think the first directory you bookmark works, but if you try adding another one Xfe crashes. The bookmarks are successfully added though.

2. All bookmark operations using the Places panel (modify, remove, move up/down) also cause a crash.

Xfe 2.1.4, with a new profile.

[Roland Baudin]

Thanks. I can't reproduce the bug. Could you give me more details: what is your system? Did you compile Xfe by yourself? Did you use some custom option when compiling?

[beastie]

FreeBSD 14.3, official package (https://cgit.freebsd.org/ports/tree/x11-fm/xfe/Makefile).

[Roland Baudin]

I fixed the bug in the new 2.1.5 version. Could you test it please in FreeBSD?

[Mamoru TASAKA]

I tried 1. i.e.

but if you try adding another one Xfe crashes.

and crash is reproducible, on Fedora 44:

/usr/include/c++/16/bits/stl_vector.h:1253: constexpr std::vector<_Tp, _Alloc>::reference std::vector<_Tp, _Alloc>::operator[](size_type) [with _Tp = FX::FXMenuCommand*; _Alloc = std::allocator<FX::FXMenuCommand*>; reference = FX::FXMenuCommand*&; size_type = long unsigned int]: Assertion '__n < this->size()' failed.

Program received signal SIGABRT, Aborted.
__pthread_kill_implementation (threadid=<optimized out>, signo=signo@entry=6, no_tid=no_tid@entry=0) at pthread_kill.c:44
44        return INTERNAL_SYSCALL_ERROR_P (ret) ? INTERNAL_SYSCALL_ERRNO (ret) : 0;

(gdb) bt
#0  __pthread_kill_implementation (threadid=<optimized out>, signo=signo@entry=6, no_tid=no_tid@entry=0) at pthread_kill.c:44
#1  0x00007ffff747aa73 in __pthread_kill_internal (threadid=<optimized out>, signo=6) at pthread_kill.c:89
#2  0x00007ffff741f34e in __GI_raise (sig=sig@entry=6) at ../sysdeps/posix/raise.c:26
#3  0x00007ffff74067b3 in __GI_abort () at abort.c:77
#4  0x00007ffff760b40a in std::__glibcxx_assert_fail(char const*, int, char const*, char const*) () from /lib64/libstdc++.so.6
#5  0x000055555557ee23 in std::vector<FX::FXMenuCommand*, std::allocator<FX::FXMenuCommand*> >::operator[](unsigned long) [clone .part.0] [clone .lto_priv.0] (__n=<optimized out>, 
    this=<optimized out>) at /usr/include/c++/16/bits/stl_vector.h:1253
#6  0x000055555569d0d5 in std::vector<FX::FXMenuCommand*, std::allocator<FX::FXMenuCommand*> >::operator[] (this=0x5555558c7968, __n=<optimized out>)
    at /usr/include/c++/16/bits/stl_vector.h:1251
#7  XFileExplorer::onUpdBookmarksMenu (this=0x5555558c7580, sender=<optimized out>, ptr=<optimized out>) at /usr/src/debug/xfe-2.1.4-1.fc44.x86_64/src/XFileExplorer.cpp:4418
#8  0x00007ffff7b8e09b in FX::FXObject::tryHandle (this=<optimized out>, sender=<optimized out>, sel=<optimized out>, ptr=0x0) at /usr/src/debug/fox-1.6.59-3.fc44.x86_64/src/FXObject.cpp:292
#9  FX::FXWindow::onUpdate (this=<optimized out>) at /usr/src/debug/fox-1.6.59-3.fc44.x86_64/src/FXWindow.cpp:2011
#10 0x00007ffff7ae6645 in FX::FXMenuCaption::onUpdate (this=0x555555912170, sender=<optimized out>, sel=<optimized out>, ptr=<optimized out>)
    at /usr/src/debug/fox-1.6.59-3.fc44.x86_64/src/FXMenuCaption.cpp:221
#11 0x00005555556a3a4a in FX::FXApp::getNextEvent (this=0x555555789120, ev=..., blocking=true) at /usr/src/debug/xfe-2.1.4-1.fc44.x86_64/src/foxhacks.cpp:1614
#12 0x00005555556b2f82 in FX::FXApp::runOneEvent (this=0x555555789120, blocking=<optimized out>) at /usr/src/debug/xfe-2.1.4-1.fc44.x86_64/src/main.cpp:180
#13 0x00007ffff7a3525d in FX::FXApp::run (this=this@entry=0x555555789120) at /usr/src/debug/fox-1.6.59-3.fc44.x86_64/src/FXApp.cpp:3092
#14 0x0000555555581006 in main (argc=<optimized out>, argv=<optimized out>) at /usr/src/debug/xfe-2.1.4-1.fc44.x86_64/src/main.cpp:584

Perhaps you have to add -Wp,-D_GLIBCXX_ASSERTIONS to CXXFLAGS, ref:
https://gcc.gnu.org/wiki/LibstdcxxDebugMode

[Roland Baudin]

I tried to download Fedora 44, but the current version is 43. Does the crash happen in 43 too?

[Mamoru TASAKA]

Now I tried Fedora 43 (LXDE) and yes, this crash is reproducible on Fedora 43.

[Roland Baudin]

OK, thanks. I released today a new version (2.1.5) with the bug fixed. Could you test it please?

[Mamoru TASAKA]

For me the problem seems fixed with 2.1.5, thank you.

[Roland Baudin]

Fine, thanks!

[вдмЪ]

FreeBSD 15
I had the same problem. Now, after updating to v. 2.1.5, everything works without errors. Thank you.

[beastie]

It works like a charm. Thank you.

[beastie]

I think you can close this one. Thanks again.