#185 New 1.35 custom script feature does not compile on OpenBSD.

v1.0_(example)
closed-fixed
nobody
None
5
2013-11-28
2013-08-24
ibara2
No

As stated in the title, the new custom script feature causes the build to fail on OpenBSD. The relevant part of the build, plus patches that allow xfe-1.35 to build and run on OpenBSD are attached in a tarball. Of course, these patches mean that the new custom script feature does not work on OpenBSD, but xfe otherwise works OK as it has in previous versions.

Is the custom script feature supposed to be working on non-Linux systems?

1 Attachments

Discussion

  • Roland Baudin

    Roland Baudin - 2013-08-25

    Hi,
    thanks for the patches. Anyway, could you attach the compilation log ? It's probably a small problem with headers or so, and I'd like to fix this quickly...
    Thanks,
    RB

     
  • ibara2

    ibara2 - 2013-08-25

    Sure. Full log attached.

     
  • Roland Baudin

    Roland Baudin - 2013-08-26

    Oh, I see: in FilePanel.cpp, the onCmdGoScriptDir() and onCmdRunScript() are by mistake placed between #if defined(linux) #endif directives, thus in non Linux systems these functions are not available.
    I attach a patch.
    Sorry for the trouble...
    Thanks for the bug report,
    RB

     
  • ibara2

    ibara2 - 2013-08-26

    That fixes it. Thanks for the quick response!

     
  • beastie

    beastie - 2013-09-03

    Thank you for the new version and these patches!

     
  • Roland Baudin

    Roland Baudin - 2013-11-28

    The bug is fixed in Xfe 1.37.
    Thanks for the report,
    RB

     
  • Roland Baudin

    Roland Baudin - 2013-11-28
    • status: open --> closed-fixed
     

Log in to post a comment.