Hi there,
Here are my comments.
1) I really liked that doxygen documentation was used. This is something
that we all must do.
2) All enums should have names (second in paqfiles.h does not have it).
Also, enum constants should have prefixes as suggested by RK.
3) String should be used whereever information is a text, for example,
fileName in paqfile.h.
4) //! Current file pointer
Char *ptr;
And all other pointers to file data should not use Char*, but Int8*. =
This is
mostly for clarity.
5) Several method names in PAQFileAllocationTable class are confusing, =
for
example:
nameResolutionAddFilename(Char *filename);
nameResolutionRemoveFilename(Char *filename);
nameResolutionRemoveFilename(UInt32 filenameHash);
Method name must start with a verb to indicate an action.
6) Char *nameResolutionStringArray; in PAQFileAllocationTable class =
should
have the type of array or something, but not char*.
7) filename in PAQFilenameResolutionDescriptor class should be a string, =
not
char*.
8) I did not understand the function the isFileUpdated method in
paqmanager.h file will be performing. What update is it checking?
9) Bool should be used instead of bool.
In general, it really looks allright. As you have noticed I had very few
comments on the method functionality.
I guess you will also provide an executable to work with the PAQ file as
well as used switches and options.
Regards,
mamutas
---
Outgoing mail is certified Virus Free.
Checked by AVG anti-virus system (http://www.grisoft.com).
Version: 6.0.489 / Virus Database: 288 - Release Date: 6/10/2003
=20
|
