Re: [Xenocide-programming] xnet db loader

[Chris P. <chr...@ju...>]

No need to apologize, being critical is a good thing in my opinion.

Those are all good suggestions.  I think I'll get the XNDL working
w/ a regular list first.  We can always upgrade it if needed.  The
difference in performance probably won't be noticeable, but an
improved data structure may help free up a few resources for more
processor intensive areas.

Well you're right about separating the data.  Since it's been decided
not to create structs outside of the data class, then it isn't as
necessary
to separate it.  Separating it would again result in a very slight
decrease
in overhead, since the loader could be destroyed once parsing is
complete.
It's not likely to be noticeable.  What we would have would be two
structs
nested in a class, which is itself nested in a class.

Regards,
chrisp

On Mon, 6 Oct 2003 21:51:32 -0500 "mamutas" <ma...@pr...>
writes:
> Hi,
> 
> I just had a chance to look through your code. Here are my 
> comments:
> 
> 1) Use longer, more descriptive variable names. It is fairly 
> difficult to
> understand what 'p' or 'hGen' might stand for.
> 2) Use types defined in utility/src/utility/common/win32/types.h. 
> This will
> help in compiler and OS porting in the future.
> 3) I don't think we need two separate classes XNDL and Xdata. I 
> thought
> about just one class which would have a load() method (which does 
> parsing at
> the same time) and then provides getSubject() and getEntry() 
> methods.
> 4) Subject and Entry class should have a 'key' variable, which will 
> hold a
> unique key for such object. It could be a string or an integer, does 
> not
> matter. The point is that access to these objects will be done by 
> keys, and
> not by their names, which could be spelled differently in different
> languages. This as well should be reflected in xml file.
> 5) addSubject() and addEntry() are private methods, right?
> 
> Also, check periodicall a thread about Xnet names, there is a file 
> in work
> listing all names as they will appear in the game.
> 
> Just FYI, here is a source code for skip lists:
> http://epaperpress.com/sortsearch/txt/skl.txt
> I am not quite sure whether we need such complicated data structure 
> for Xnet
> DB, since the hierarchy is very simple and there are not many 
> entries
> anyways. I would use something like a simple list of lists myself.
> 
> Thanks for your work. I apologize, if I was criticising too much.
> 
> Regards,
> mamutas  
> 
> -----Original Message-----
> From: xen...@li...
> [mailto:xen...@li...] On Behalf 
> Of Chris
> Phillips
> Sent: Thursday, October 02, 2003 9:03 PM
> To: Xen...@li...
> Subject: [Xenocide-programming] xnet db loader
> 
> 
> 
> Hey everyone,
> 
> Sorry I've been out of touch for so long.  I've been busy moving and 
> w/ a
> new job.  I haven't had much time to work on the XNet db loader 
> during the
> past few weeks, so I figured I should go 
> ahead and post the header files as they are.  So.. here are the 
> header files
> w/ some basic documentation.  I used my own string class, which 
> should
> definitely be changed.  I also used my Skip List.  Which can be 
> changed
> also.  The files are attached.  Let me 
> know what changes should be made. I'll try and set aside some time 
> to get
> this done.  :)
> 
> 
> -chrisp
> 
> ---
> Incoming mail is certified Virus Free.
> Checked by AVG anti-virus system (http://www.grisoft.com).
> Version: 6.0.514 / Virus Database: 312 - Release Date: 2003/08/28
>  
>           
> 
> ---
> Outgoing mail is certified Virus Free.
> Checked by AVG anti-virus system (http://www.grisoft.com).
> Version: 6.0.514 / Virus Database: 312 - Release Date: 2003/08/28
>  
> 
> 
> 

________________________________________________________________
The best thing to hit the internet in years - Juno SpeedBand!
Surf the web up to FIVE TIMES FASTER!
Only $14.95/ month - visit www.juno.com to sign up today!