Re: [Xenocide-programming] PAQ Files latest corrections

[Federico A. L. <fl...@ma...>]

> - add:
> PAQSolidFileManipulator::setEndOfFile to change file size (trunc 
> 
> useless data to do not waste space)
> 
> This was intented to be used only by the .FAT manager to truncate the
> file if the size of the new saved one is smaller than before. But this
> can be ignored till we do the defragmentation... so ok this function if
> useless ^_^

> I've not understood why the use of the pair is forbidden... what are
> public attributes?
Public attributes are public variables like the one that you are using in the 
pair from the STL. Not in your code, but I prefer do not let anyone use that to 
be consistent. If you want you can make a new pair template with a 
setFirstArgument and getFirstArgument, and the same for the second one.

> I think I have made a mistake posting the .cpp files so early. The code
> is pretty young, it is intended only to show a sort of work-flow of the
> functions, to clearify what they do.
Dont worry about it, better to make that now, after the design is more or less 
polished, dont get discourage you will have to change lots of things now, what 
it sounded fine when designing wont look that good when implementing, but that 
happens all the time... So you would ask why to design the headers first, 
because you setup the working policy and phylosophy doing that, so you end up 
with a better system when implementing. In short you design the most deseable 
and implement something a little worse, but that is just the way of the world. 

> I personally think the second code if more clear, expecially with the
> searching. But a person who doesn't know STL may find it difficult to
> understand. Tell me what you think about it.

Dont be so sure, cause inside you are using a for but when you read the code 
you are not aware of the control flow. The design should be the best you can 
do, and the implementation the most readable and self explaining that you can. 
If you have a loop control flow you need to see it to know that what you are 
doing is right, besides you dont need an extra knowledge (Know STL by heart, in 
fact i just use the vector and string class cause they are very well designed 
not the rest, cause some parts of it are very dificult to understand).

> I'd like to say something on the networklib... but I had a quick read at
> the headers and I found nothing missing :-)

Dont be afraid, I make mistakes too and I can bet that I commited lots, in fact 
the actual one (not posted yet) had changed a lot to make it easier to code and 
understand... We had missed in some points, so we went an step backwards and 
revised all the work and found better ways to do some things, so the new one 
will have some new things (and documentation)...

Greetings
Red Knight