Re: [Xenocide-programming] PAQ Files latest corrections

SourceForge Headquarters 1320 Columbia Street Suite 310 San Diego, CA 92101 +1 (858) 422-6466

<html>
<blockquote type=cite class=cite cite>- add:
PAQSolidFileManipulator::setEndOfFile to change file size (trunc 
useless data to do not waste space)</blockquote> 
This was intented to be used only by the .FAT manager to truncate the
file if the size of the new saved one is smaller than before. But this
can be ignored till we do the defragmentation... so ok this function if
useless ^_^ 
I've not understood why the use of the pair is forbidden... what are
public attributes? 
The variables are set to private, which are not visible in derived
classes too.. 
I think I have made a mistake posting the .cpp files so early. The code
is pretty young, it is intended only to show a sort of work-flow of the
functions, to clearify what they do. 
Later in development I'll revise all the code and I am intentioned to try
to remove the for() cycles for searching etc. and replace them with the
STL templates, if this will be enough clear in the code. For 
example 
Before: 
<x-tab>&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;</x-tab>UInt32
size; 
<x-tab>&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;</x-tab>size =
this-&gt;freeSolidFileManipulators.size(); 
<x-tab>&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;</x-tab>for(Index
i=0;i&lt;size;i++) 
<x-tab>&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;</x-tab><x-tab>&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;</x-tab>delete
this-&gt;freeSolidFileManipulators[i]; 
<x-tab>&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;</x-tab>this-&gt;freeSolidFileManipulators.clear(); 
After: 
<x-tab>&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;</x-tab>vector&lt;PAQSolidFileManipulator
*&gt;::iterator begin,end; 
<x-tab>&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;</x-tab>begin =
this-&gt;freeSolidFileManipulators.begin(); 
<x-tab>&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;</x-tab>end =
this-&gt;freeSolidFileManipulators.end(); 
<x-tab>&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;</x-tab>std::for_each(begin,end,deleteSolidManipulator()); 
The disadvantage is that I have to write additional things to make it
work. In the previous example I must add too: 
<x-tab>&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;</x-tab>struct
deleteSolidManipulator : public
std::unary_function&lt;PAQSolidFileManipulator *,void&gt; 
<x-tab>&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;</x-tab>{ 
<x-tab>&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;</x-tab><x-tab>&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;</x-tab>deleteSolidManipulator::result_type
operator()(deleteSolidManipulator::argument_type x) { delete x; }; 
<x-tab>&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;</x-tab>}; 
I personally think the second code if more clear, expecially with the
searching. But a person who doesn't know STL may find it difficult to
understand. Tell me what you think about it. 
Anyway, the modifications you posted has been applied. 
Thanks 
I'd like to say something on the networklib... but I had a quick read at
the headers and I found nothing missing :-) 
Exio82 
</html>