[XenAccess-devel] small patch

[<to...@ji...>]

Hi,
I am trying to understand internals of xenaccess and while reading the 
code I fixed some things:

- added documentation for configuration file
- added checking of libxenctrl and libxenstore
- added comments to functions in xa_private.h
- simpler offset counting in linux_access_machine_address_rw


Btw.:

1) In xa_cache.c shouldn't the memory pointed by mach_address be 
munmapped when
releasing cache item?
2) in xenaccess/xa_memory.c in function xa_mmap_pfn() why is there 
XC_PAGE_SIZE instead of
1
3) Why do you do page translation via linux_pagetable_lookup() in 
xenaccess/linux_memory.c?
I think I see the principle but there is the 
xc_translate_foreign_address() function used in
xa_access_virtual_address() in commented test code. Why don't you use 
it? Are there any caveats
or advantages of your approach that I don't see? :)

Thanks in advance for answers.

-- 
Tomas Kouba