#406 xdvi fails to build w/ gcc-14

[Hilmar Preuße]

Down here in the Debian bug tracking system it was noticed that xdvi fails to build when using gcc-14:

gcc -DHAVE_CONFIG_H -I. -I../../../texk/xdvik -I../../../texk/xdvik/gui -DPS_G -I/home/hille/gcc-14/texlive-bin-2024.20240313.70630+ds/Work/texk -I/home/hill/gcc-14/texlive-bin-2024.20240313.70630+ds/texk -I/usr/include/freetype2 -I/usrinclude/libpng16 -Wdate-time -D_FORTIFY_SOURCE=2 -Wimplicit -Wreturn-type -g-O2 -Werror=implicit-function-declaration -ffile-prefix-map=/home/hille/gcc-14/exlive-bin-2024.20240313.70630+ds=. -fstack-protector-strong -fstack-clash-protction -Wformat -Werror=format-security -fcf-protection -c -o gui/pagesel.o .././../texk/xdvik/gui/pagesel.c
../../../texk/xdvik/gui/pagesel.c: In function ‘xaw_update_list’:
../../../texk/xdvik/gui/pagesel.c:541:41: error: passing argument 2 of ‘XawListhange’ from incompatible pointer type [-Wincompatible-pointer-types]
541 | XawListChange(LIST_WIDGET, page_info.page_labels, 0,
| ~~~~~~~~~^~~~~~~~~~~~
| |
| char **
In file included from ../../../texk/xdvik/gui/pagesel.c:93:
/usr/include/X11/Xaw/List.h:170:27: note: expected ‘const char ’ but argumen tis of type ‘char ’
170 | _Xconst char **list,
| ^

The message is visible for a while now in the build logs, but until gcc-14 it seems to have been treated as warning. Please be so kind to have a look. Thank you!

[Hilmar Preuße]

I just noticed that the issue is specific to Debian and an incompatible change in libxaw7. Debian still has version 1.0.14, meanwhile the issue would not exist, when 1.0.16 would have been packaged.

Here is the changelog from the libxaw source:

commit d0fcbd9722ad691ca0b5873c98e8e9c236fa718b
Author: Thomas E. Dickey dickey@invisible-island.net
Date: Sun Mar 3 20:21:40 2024 -0500

amend change to XawListChange()

My previous commit in July 2019

  build-fixes when _CONST_X_STRING is defined

modified the interface of XawListChange() to use "_Xconst char *"
to fix builds when the Xt symbol _CONST_X_STRING is defined (which
makes the String typedef "const").

While this fixed building Xaw, clients which use Xaw were impacted.
Changing that function to use String resolves both problems.

(report by Karl Berry).

Signed-off-by: Thomas E. Dickey <dickey@invisible-island.net>

Feel free to close the issue,