xdoclet-plugins-interest

[xdoclet-plugins-interest] [jira] Created: (XDP-240) EJB Plugin doesn't parse EJB super class for xdoclet tags and doesn't put their description into ejb-jar.xml

[Konstantin K. (JIRA) <ji...@co...>]

EJB Plugin doesn't parse EJB super class for xdoclet tags and doesn't put their description into ejb-jar.xml
------------------------------------------------------------------------------------------------------------

                 Key: XDP-240
                 URL: http://jira.codehaus.org/browse/XDP-240
             Project: XDoclet 2 Plugins
          Issue Type: Bug
          Components: ejb
    Affects Versions: 1.0.0, 1.0.1, 1.0.2, 1.0.3, 1.0.5, 1.0.4
         Environment: JDK 1.5
ANT 1.7
            Reporter: Konstantin Kasatkin
            Priority: Critical
         Attachments: xdoclet2.zip

It doesn't parse EJB super class for xdoclet tags and doesn't put their description into ejb-jar.xml.
XDoclet1 really did that, because I remember that I personally set this issue against project team.

I have an 2 super classes for the EJB and a super interface for EJB Interface looking like

public abstract class AbstractSessionBean implements SessionBean {...}

public class AsyncPipesImpl extends AbstractSessionBean implements AsyncPipes {

...some business methods with xdoclet declarations...
/**
     * @ejb.interface-method
     * @ejb.transaction-method type="Supports"
*/
    public void additionalMethods () { ... implementation ... }
}

public interface AsyncPipes extends Serializable {

    public void additionalMethods();
}


EJB class is declared as:

/*
* @ejb.bean ...
* @ejb.interface extends="AsyncPipesImpl,javax.ejb.EJBObject"
*                local-extends=" AsyncPipes,javax.ejb.EJBLocalObject"
*/
public class ImportEJB extends AsyncPipesImpl {
    ... implementation ...
}

When I run EjbJarXmlPlugin I see that all declarations in AsyncPipesImpl are ignored and ejb-jar.xml doesn't contain any of its methods.

Same behavior with EjbConfig plugin, it doesn't check validity of xdoclet descriptors in the AsyncPipesImpl.

Aslo I've noticed that EJB plugin generates nothing if I don't add "implements SessionBean" explicitly in declaration of ImportEJB class, however it would get this information from super class, so I have to put unnecessary declaration.


-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[xdoclet-plugins-interest] [jira] Commented: (XDP-240) EJB Plugin doesn't parse EJB super class for xdoclet tags and doesn't put their description into ejb-jar.xml

[Konstantin K. (JIRA) <ji...@co...>]

    [ http://jira.codehaus.org/browse/XDP-240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=168118#action_168118 ] 

Konstantin Kasatkin commented on XDP-240:
-----------------------------------------

111

> EJB Plugin doesn't parse EJB super class for xdoclet tags and doesn't put their description into ejb-jar.xml
> ------------------------------------------------------------------------------------------------------------
>
>                 Key: XDP-240
>                 URL: http://jira.codehaus.org/browse/XDP-240
>             Project: XDoclet 2 Plugins
>          Issue Type: Bug
>          Components: ejb
>    Affects Versions: 1.0.5, 1.0.4, 1.0.3, 1.0.2, 1.0.1, 1.0.0
>         Environment: JDK 1.5
> ANT 1.7
>            Reporter: Konstantin Kasatkin
>            Priority: Critical
>         Attachments: xdoclet2.zip
>
>
> It doesn't parse EJB super class for xdoclet tags and doesn't put their description into ejb-jar.xml.
> XDoclet1 really did that, because I remember that I personally set this issue against project team.
> I have an 2 super classes for the EJB and a super interface for EJB Interface looking like
> public abstract class AbstractSessionBean implements SessionBean {...}
> public class AsyncPipesImpl extends AbstractSessionBean implements AsyncPipes {
> ...some business methods with xdoclet declarations...
> /**
>      * @ejb.interface-method
>      * @ejb.transaction-method type="Supports"
> */
>     public void additionalMethods () { ... implementation ... }
> }
> public interface AsyncPipes extends Serializable {
>     public void additionalMethods();
> }
> EJB class is declared as:
> /*
> * @ejb.bean ...
> * @ejb.interface extends="AsyncPipesImpl,javax.ejb.EJBObject"
> *                local-extends=" AsyncPipes,javax.ejb.EJBLocalObject"
> */
> public class ImportEJB extends AsyncPipesImpl {
>     ... implementation ...
> }
> When I run EjbJarXmlPlugin I see that all declarations in AsyncPipesImpl are ignored and ejb-jar.xml doesn't contain any of its methods.
> Same behavior with EjbConfig plugin, it doesn't check validity of xdoclet descriptors in the AsyncPipesImpl.
> Aslo I've noticed that EJB plugin generates nothing if I don't add "implements SessionBean" explicitly in declaration of ImportEJB class, however it would get this information from super class, so I have to put unnecessary declaration.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[xdoclet-plugins-interest] [jira] Commented: (XDP-240) EJB Plugin doesn't parse EJB super class for xdoclet tags and doesn't put their description into ejb-jar.xml

[Konstantin K. (JIRA) <ji...@co...>]

    [ http://jira.codehaus.org/browse/XDP-240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=168119#action_168119 ] 

Konstantin Kasatkin commented on XDP-240:
-----------------------------------------

Some additional comments about attachment.
Archive xdoclet2.zip contains java source including xdoclet tags code for processing
and Atn build script.

Also it contains xdoclet1-generated.zip archive that 
is a result of processing the same source code by xdoclet1 framework.
It is an example for EJB plugin how it should really work.

> EJB Plugin doesn't parse EJB super class for xdoclet tags and doesn't put their description into ejb-jar.xml
> ------------------------------------------------------------------------------------------------------------
>
>                 Key: XDP-240
>                 URL: http://jira.codehaus.org/browse/XDP-240
>             Project: XDoclet 2 Plugins
>          Issue Type: Bug
>          Components: ejb
>    Affects Versions: 1.0.5, 1.0.4, 1.0.3, 1.0.2, 1.0.1, 1.0.0
>         Environment: JDK 1.5
> ANT 1.7
>            Reporter: Konstantin Kasatkin
>            Priority: Critical
>         Attachments: xdoclet2.zip
>
>
> It doesn't parse EJB super class for xdoclet tags and doesn't put their description into ejb-jar.xml.
> XDoclet1 really did that, because I remember that I personally set this issue against project team.
> I have an 2 super classes for the EJB and a super interface for EJB Interface looking like
> public abstract class AbstractSessionBean implements SessionBean {...}
> public class AsyncPipesImpl extends AbstractSessionBean implements AsyncPipes {
> ...some business methods with xdoclet declarations...
> /**
>      * @ejb.interface-method
>      * @ejb.transaction-method type="Supports"
> */
>     public void additionalMethods () { ... implementation ... }
> }
> public interface AsyncPipes extends Serializable {
>     public void additionalMethods();
> }
> EJB class is declared as:
> /*
> * @ejb.bean ...
> * @ejb.interface extends="AsyncPipesImpl,javax.ejb.EJBObject"
> *                local-extends=" AsyncPipes,javax.ejb.EJBLocalObject"
> */
> public class ImportEJB extends AsyncPipesImpl {
>     ... implementation ...
> }
> When I run EjbJarXmlPlugin I see that all declarations in AsyncPipesImpl are ignored and ejb-jar.xml doesn't contain any of its methods.
> Same behavior with EjbConfig plugin, it doesn't check validity of xdoclet descriptors in the AsyncPipesImpl.
> Aslo I've noticed that EJB plugin generates nothing if I don't add "implements SessionBean" explicitly in declaration of ImportEJB class, however it would get this information from super class, so I have to put unnecessary declaration.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[xdoclet-plugins-interest] [jira] Commented: (XDP-240) EJB Plugin doesn't parse EJB super class for xdoclet tags and doesn't put their description into ejb-jar.xml

[Konstantin K. (JIRA) <ji...@co...>]

    [ http://jira.codehaus.org/browse/XDP-240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=168120#action_168120 ] 

Konstantin Kasatkin commented on XDP-240:
-----------------------------------------

I've just found one more issue in processing @ejb.interface extends attribute.
If I declare @ejb.interface extends="AsyncPipesImpl,javax.ejb.EJBObject"
(with no space between class declaration) all works fine. But when I add a space
before or after comma, Plugin doesn't trim space and consider clal name as
"<space>javax.ejb.EJBObject" and in the generated code it adds javax.ejb.EJBObject twice
because it thinks that it two different classes "<space>javax.ejb.EJBObject" and "javax.ejb.EJBObject".

> EJB Plugin doesn't parse EJB super class for xdoclet tags and doesn't put their description into ejb-jar.xml
> ------------------------------------------------------------------------------------------------------------
>
>                 Key: XDP-240
>                 URL: http://jira.codehaus.org/browse/XDP-240
>             Project: XDoclet 2 Plugins
>          Issue Type: Bug
>          Components: ejb
>    Affects Versions: 1.0.5, 1.0.4, 1.0.3, 1.0.2, 1.0.1, 1.0.0
>         Environment: JDK 1.5
> ANT 1.7
>            Reporter: Konstantin Kasatkin
>            Priority: Critical
>         Attachments: xdoclet2.zip
>
>
> It doesn't parse EJB super class for xdoclet tags and doesn't put their description into ejb-jar.xml.
> XDoclet1 really did that, because I remember that I personally set this issue against project team.
> I have an 2 super classes for the EJB and a super interface for EJB Interface looking like
> public abstract class AbstractSessionBean implements SessionBean {...}
> public class AsyncPipesImpl extends AbstractSessionBean implements AsyncPipes {
> ...some business methods with xdoclet declarations...
> /**
>      * @ejb.interface-method
>      * @ejb.transaction-method type="Supports"
> */
>     public void additionalMethods () { ... implementation ... }
> }
> public interface AsyncPipes extends Serializable {
>     public void additionalMethods();
> }
> EJB class is declared as:
> /*
> * @ejb.bean ...
> * @ejb.interface extends="AsyncPipesImpl,javax.ejb.EJBObject"
> *                local-extends=" AsyncPipes,javax.ejb.EJBLocalObject"
> */
> public class ImportEJB extends AsyncPipesImpl {
>     ... implementation ...
> }
> When I run EjbJarXmlPlugin I see that all declarations in AsyncPipesImpl are ignored and ejb-jar.xml doesn't contain any of its methods.
> Same behavior with EjbConfig plugin, it doesn't check validity of xdoclet descriptors in the AsyncPipesImpl.
> Aslo I've noticed that EJB plugin generates nothing if I don't add "implements SessionBean" explicitly in declaration of ImportEJB class, however it would get this information from super class, so I have to put unnecessary declaration.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[xdoclet-plugins-interest] [jira] Commented: (XDP-240) EJB Plugin doesn't parse EJB super class for xdoclet tags and doesn't put their description into ejb-jar.xml

[Konstantin P. (JIRA) <ji...@co...>]

    [ http://jira.codehaus.org/browse/XDP-240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=168373#action_168373 ] 

Konstantin Pribluda commented on XDP-240:
-----------------------------------------

Supplied example  excludes abstract base class from file set feed to xdoclet:

     <fileset dir="src">
        <include name="**/*EJB.java"/>
      </fileset>         

Thus it will never see it. 

As for your last comment - this belongs in separate issue 

> EJB Plugin doesn't parse EJB super class for xdoclet tags and doesn't put their description into ejb-jar.xml
> ------------------------------------------------------------------------------------------------------------
>
>                 Key: XDP-240
>                 URL: http://jira.codehaus.org/browse/XDP-240
>             Project: XDoclet 2 Plugins
>          Issue Type: Bug
>          Components: ejb
>    Affects Versions: 1.0.5, 1.0.4, 1.0.3, 1.0.2, 1.0.1, 1.0.0
>         Environment: JDK 1.5
> ANT 1.7
>            Reporter: Konstantin Kasatkin
>            Priority: Critical
>         Attachments: xdoclet2.zip
>
>
> It doesn't parse EJB super class for xdoclet tags and doesn't put their description into ejb-jar.xml.
> XDoclet1 really did that, because I remember that I personally set this issue against project team.
> I have an 2 super classes for the EJB and a super interface for EJB Interface looking like
> public abstract class AbstractSessionBean implements SessionBean {...}
> public class AsyncPipesImpl extends AbstractSessionBean implements AsyncPipes {
> ...some business methods with xdoclet declarations...
> /**
>      * @ejb.interface-method
>      * @ejb.transaction-method type="Supports"
> */
>     public void additionalMethods () { ... implementation ... }
> }
> public interface AsyncPipes extends Serializable {
>     public void additionalMethods();
> }
> EJB class is declared as:
> /*
> * @ejb.bean ...
> * @ejb.interface extends="AsyncPipesImpl,javax.ejb.EJBObject"
> *                local-extends=" AsyncPipes,javax.ejb.EJBLocalObject"
> */
> public class ImportEJB extends AsyncPipesImpl {
>     ... implementation ...
> }
> When I run EjbJarXmlPlugin I see that all declarations in AsyncPipesImpl are ignored and ejb-jar.xml doesn't contain any of its methods.
> Same behavior with EjbConfig plugin, it doesn't check validity of xdoclet descriptors in the AsyncPipesImpl.
> Aslo I've noticed that EJB plugin generates nothing if I don't add "implements SessionBean" explicitly in declaration of ImportEJB class, however it would get this information from super class, so I have to put unnecessary declaration.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[xdoclet-plugins-interest] [jira] Commented: (XDP-240) EJB Plugin doesn't parse EJB super class for xdoclet tags and doesn't put their description into ejb-jar.xml

[Konstantin K. (JIRA) <ji...@co...>]

    [ http://jira.codehaus.org/browse/XDP-240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=168726#action_168726 ] 

Konstantin Kasatkin commented on XDP-240:
-----------------------------------------

If I add my superclasses into processed source fileset I get very messy result,
xDoclet begins to generate interfaces for superclasses, in one word all goes worse than without adding:(

> EJB Plugin doesn't parse EJB super class for xdoclet tags and doesn't put their description into ejb-jar.xml
> ------------------------------------------------------------------------------------------------------------
>
>                 Key: XDP-240
>                 URL: http://jira.codehaus.org/browse/XDP-240
>             Project: XDoclet 2 Plugins
>          Issue Type: Bug
>          Components: ejb
>    Affects Versions: 1.0.5, 1.0.4, 1.0.3, 1.0.2, 1.0.1, 1.0.0
>         Environment: JDK 1.5
> ANT 1.7
>            Reporter: Konstantin Kasatkin
>            Priority: Critical
>         Attachments: xdoclet2.zip
>
>
> It doesn't parse EJB super class for xdoclet tags and doesn't put their description into ejb-jar.xml.
> XDoclet1 really did that, because I remember that I personally set this issue against project team.
> I have an 2 super classes for the EJB and a super interface for EJB Interface looking like
> public abstract class AbstractSessionBean implements SessionBean {...}
> public class AsyncPipesImpl extends AbstractSessionBean implements AsyncPipes {
> ...some business methods with xdoclet declarations...
> /**
>      * @ejb.interface-method
>      * @ejb.transaction-method type="Supports"
> */
>     public void additionalMethods () { ... implementation ... }
> }
> public interface AsyncPipes extends Serializable {
>     public void additionalMethods();
> }
> EJB class is declared as:
> /*
> * @ejb.bean ...
> * @ejb.interface extends="AsyncPipesImpl,javax.ejb.EJBObject"
> *                local-extends=" AsyncPipes,javax.ejb.EJBLocalObject"
> */
> public class ImportEJB extends AsyncPipesImpl {
>     ... implementation ...
> }
> When I run EjbJarXmlPlugin I see that all declarations in AsyncPipesImpl are ignored and ejb-jar.xml doesn't contain any of its methods.
> Same behavior with EjbConfig plugin, it doesn't check validity of xdoclet descriptors in the AsyncPipesImpl.
> Aslo I've noticed that EJB plugin generates nothing if I don't add "implements SessionBean" explicitly in declaration of ImportEJB class, however it would get this information from super class, so I have to put unnecessary declaration.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[xdoclet-plugins-interest] [jira] Commented: (XDP-240) EJB Plugin doesn't parse EJB super class for xdoclet tags and doesn't put their description into ejb-jar.xml

[Konstantin P. (JIRA) <ji...@co...>]

    [ http://jira.codehaus.org/browse/XDP-240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=168734#action_168734 ] 

Konstantin Pribluda commented on XDP-240:
-----------------------------------------

current workaround would be to implement javax.ejb.* in leaf classes

current logic determining whether to generate classes definitely needs attention
( patches as always welcome ) 

> EJB Plugin doesn't parse EJB super class for xdoclet tags and doesn't put their description into ejb-jar.xml
> ------------------------------------------------------------------------------------------------------------
>
>                 Key: XDP-240
>                 URL: http://jira.codehaus.org/browse/XDP-240
>             Project: XDoclet 2 Plugins
>          Issue Type: Bug
>          Components: ejb
>    Affects Versions: 1.0.5, 1.0.4, 1.0.3, 1.0.2, 1.0.1, 1.0.0
>         Environment: JDK 1.5
> ANT 1.7
>            Reporter: Konstantin Kasatkin
>            Priority: Critical
>         Attachments: xdoclet2.zip
>
>
> It doesn't parse EJB super class for xdoclet tags and doesn't put their description into ejb-jar.xml.
> XDoclet1 really did that, because I remember that I personally set this issue against project team.
> I have an 2 super classes for the EJB and a super interface for EJB Interface looking like
> public abstract class AbstractSessionBean implements SessionBean {...}
> public class AsyncPipesImpl extends AbstractSessionBean implements AsyncPipes {
> ...some business methods with xdoclet declarations...
> /**
>      * @ejb.interface-method
>      * @ejb.transaction-method type="Supports"
> */
>     public void additionalMethods () { ... implementation ... }
> }
> public interface AsyncPipes extends Serializable {
>     public void additionalMethods();
> }
> EJB class is declared as:
> /*
> * @ejb.bean ...
> * @ejb.interface extends="AsyncPipesImpl,javax.ejb.EJBObject"
> *                local-extends=" AsyncPipes,javax.ejb.EJBLocalObject"
> */
> public class ImportEJB extends AsyncPipesImpl {
>     ... implementation ...
> }
> When I run EjbJarXmlPlugin I see that all declarations in AsyncPipesImpl are ignored and ejb-jar.xml doesn't contain any of its methods.
> Same behavior with EjbConfig plugin, it doesn't check validity of xdoclet descriptors in the AsyncPipesImpl.
> Aslo I've noticed that EJB plugin generates nothing if I don't add "implements SessionBean" explicitly in declaration of ImportEJB class, however it would get this information from super class, so I have to put unnecessary declaration.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira