#74 macOS install script: security issues

[nohillside]

Hi there,

I didn't find the source for the macOS install script so I add this here instead. The script in the DMG creates some significant security issues by running chmod 777 on the binaries installed. This is unneccessary, doing

chmod 755 $APP_JRE/bin/java
chmod 755 /Applications/xdm.app/Contents/MacOS/xdman
chmod 755 /Applications/xdm.app/Contents/MacOS/youtube-dl
chmod 755 /Applications/xdm.app/Contents/MacOS/ffmpeg

is enough (and will prevent others from silently overwritting the files).

While you are at it, maybe you can also replace this call (and get rid of the python scriplet)

/Volumes/XDMSetup/copy.py

with

cp /Volumes/XDMSetup/xdm.app.tar.xz /tmp/

or get rid of the copy part altogether by just running

tar -xvf "/Volumes/XDMSetup/xdm.app.tar.xz" -C /Applications

directly.