extraneous boxes with a "?" appended to directory entries
Brought to you by:
spitzak
Menu
▾
▴
#28 extraneous boxes with a "?" appended to directory entries
Hi, xdiskusage 1.52 worked fine on macOS but 1.53 and 1.54 don't. For each directory entry shown, an additional directory entry is shown with a "?" appended to the end. A more detailed bug report with screenshots was submitted to MacPorts but since it is not a MacPorts-specific issue I wanted to bring it to your attention. I suspect that this is fallout from 5d5f223 given the mention of the term "newline" in the commit message and the bug reporter's discovery that newlines seem to relate to the problem.
As it appears this bug is visible when a file containing du output is used, can you please generate a (small) du output file that demonstrates this bug? It must show the error when piped to xdiskusage. Attach it here and make sure the newlines are not altered.
Last edit: Bill Spitzak 2021-08-31
Actually it sure looks like the "getdelim_fallback" is not returning what the getdelim documentation says, it should return the length including the newline but the code is returning this value minus one.
A couple bugs in getdelim_fallback, easily found by compiling so it is used instead of getdelim. Should have tried that earlier. Patch pushed.
Thanks! Version 1.60 does seem to fix it.