Thanks! Version 1.60 does seem to fix it.
Bump version number
Modern fltk handles control characters in text just fine
extraneous boxes with a "?" appended to directory entries
A couple bugs in getdelim_fallback, easily found by compiling so it is used instead of getdelim. Should have tried that earlier. Patch pushed.
More email
Put author information in one place
Ticket 28: Fixes to getdelim_fallback
Actually it sure looks like the "getdelim_fallback" is not returning what the getdelim documentation says, it should return the length including the newline but the code is returning this value minus one.
As it appears this bug is visible when a file containing du output is used, can you please generate a (small) du output file that demonstrates this bug? It must show the error when piped to xdiskusage. Attach it here and make sure the newlines are not altered.
As it appears this bug is visible when a file containing du output is used, can you please generate a (small) du output file that demonstrates this bug? It must show the error when piped to xdiskusabe. Attach it here and make sure the newlines are not altered.
extraneous boxes with a "?" appended to directory entries
Add email
Bumped version number and copyright
Made copy menu item actually set the clipboard
Replace delimiter from getdelim with null
Added 'q' menu option to exit
Bump version to 1.53
Fix browser so user can choose directories
Reduce the number of variants of the getdelim function name
Application fails completely when encountering files with newlines in the name
Patched version worked great.
Patch applied! It worked great. It is in the git repository, have not built new versions yet (unclear if people use them but that is what website points to).
Arbitrary line lengths from du, handle newlines in filenames
I encountered this error today with a filename that had a newline in it for some reason. Please consider fixing the issue and/or applying this patch.
I encounterd this error today with a filename that had a newline in it for some reason. Please consider fixing the issue and/or applying this patch.
Application fails completely when encountering files with newlines in the name
Bump version to 1.52
Honor LDFLAGS (bug 25)
Honor LDFLAGS
Fixed as shown above.
Actually it has to count from the last column because the first one (the filesystem) can have spaces in it. So probably this is the best solution.
I put the -P in as suggested, but it might be better to fix the parser to skip the extra columns.
Use the same df flags on macOS as on FreeBSD and add the -P flag to
man df (on macOS 10.13 High Sierra) explains why the output is now different: -i Include statistics on the number of free inodes. This option is now the default to conform to Version 3 of the Single UNIX Specification (``SUSv3'') Use -P to sup- press this output. So we just need to add -P to the df flags to suppress it. But its description is: -P Use (the default) 512-byte blocks. This is only useful as a way to override an BLOCKSIZE specification from the environ- ment. And in the legacy section...
I would probably append user-supplied LDFLAGS after any existing flags. Here's what I've used: --- makeinclude.in.orig 2014-11-20 15:20:11.000000000 -0600 +++ makeinclude.in 2018-12-07 10:06:58.000000000 -0600 @@ -22,4 +22,6 @@ CXXFLAGS_D =@CXXFLAGS_D@ # libraries to link with: +LDFLAGS =@LDFLAGS@ + INSTALL =@INSTALL@ --- Makefile.orig 2015-02-09 17:12:19.000000000 -0600 +++ Makefile 2018-12-07 10:15:52.000000000 -0600 @@ -17,7 +17,7 @@ all: $(PROGRAM) $(PROGRAM) : $(OBJECTS) - $(CXX) -o $(PROGRAM)...
For example, this output is from Mac OS X 10.5: Filesystem 1024-blocks Used Available Capacity Mounted on /dev/disk0s3 156159792 67393780 88510012 44% / fdesc 1 1 0 100% /dev map -hosts 0 0 0 100% /net map auto_home 0 0 0 100% /home And this output is from macOS 10.14: Filesystem 1024-blocks Used Available Capacity iused ifree %iused Mounted on /dev/disk1s1 94167000 62324124 30123768 68% 1149569 9223372036853626238 0% / /dev/disk1s4 94167000 1048600 30123768 4% 1 9223372036854775806 0% /private/var/vm...
Ah. Well, that is not the code in version 1.51. I see that commit 275754a which added the FreeBSD part wasn't made until a year after 1.51 was released. Maybe it's time for a new release? If I backport that commit to 1.51, it makes no difference, because it's looking for a preprocessor define __FreeBSD__, which is not defined on macOS. If I change it to #elif defined(__FreeBSD__) || defined(__APPLE__), then the program works, to the extent that the main window appears, and I can choose a volume and...
xdiskusage-1.47 Multiple Makefile errors
The CPPFLAGS were added to the makefile some time ago.
I have generally found that if it runs out of memory it will crash long before any strdup return code can be tested for.
Should that override the attempt in the makefile to use the fltk ldflags? Or be appended to it?
Can you find out why this code at the start of xdiskusage.C does not cause the command to be the "df -k -t noprocfs,devfs,fdescfs" string? #if defined(DF_COMMAND) // assumme DU_COMMAND is also defined #elif defined(hpux) # define DF_COMMAND "df -P" # define DU_COMMAND "du -kx" #elif defined(bsdi) # define DF_COMMAND "df" # define DU_COMMAND "du -x" #elif defined(FreeBSD) # define DF_COMMAND "df -k -t noprocfs,devfs,fdescfs" # define DU_COMMAND "du -kx" #elif defined(SVR4) || defined(sun) # define...
df: illegal option -- x
Honor LDFLAGS
It looks like AC_PROG_CXX in configure.in is failing, but that is pretty standard...
Configure failed with Clang
Parameters for df(1) in FreeBSD inside DF_COMMAND
I pushed your recommended patch, looks good to me
Fixed df command for FreeBSD
Parameters for df(1) in FreeBSD inside DF_COMMAND
Reading from pipe: segfault fix
Dup of https://sourceforge.net/p/xdiskusage/bugs/19/
Yes this is a dup of ticket #19 https://sourceforge.net/p/xdiskusage/bugs/19/
Sorry, I just saw that there are much newer versions available than in gentoo and...
Reading from pipe: segfault fix
Fix leaked fd if run with a directory on the co...
Fixed .gitignore
Added .gitignore
Thanks for the quick fix, 1.51 now built for lots of OSes at: https://build.opensuse.org/package/show/home:johnberanek/xdiskusage...
Better fix for bug #22
Segmentation fault with 1.50
Fixed in version 1.51
Fix for bug #22: crash if directory given on co...
Bump version to 1.51
Fixed with this probably sub-optimally placed fix: --- xdiskusage-1.50/xdiskusage.C...
More usefully: (gdb) bt #0 0x0804ee84 in Fl_Browser_::textsize (this=0x0) at /usr/include/FL/Fl_Browser_.H:282...
Segmentation fault with 1.50
Fixed some missed version numbers
Future-proof by printing up to Yottobytes
Okay I found an acceptable solution by rearranging the columns so the disk name is...
Long disk names clipped
Disk browser appearance improvements
Clicking in blank area of disk browser does not...
Version 50, remove unused parts of configure.in
Command-line option for ps-output
Use fltk-config so it builds on more systems, s...
xdiskusage-1.47 Multiple Makefile errors
Use of fltk-config program is probably necessary. Fixed the libraries with this,...
Makefile updated to use fltk-config.
use fltk-config for libs
Escape only closes the copyright window in current version. A button would be nice...
closing copyright screen/application
Some attempts to fix disk browser window layout
broken for big partitions
Likely this was fixed by changing to long long.
-a option broken
Not working on 64 bit machines
This has been patched with (int)(long)pointer
Not much can be done with the fltk 1.x browsers
Long disk names clipped
This is fixed for fltk 1.3 as well. However Postscript output is still broken. It...
broken display of non-latin filenames
The '-' switch to pipe from stdin was ignored
Fixed crashes when you do "du * | xdiskusage -"
Thanks! Fixed. Current version requires you to give a "-" command-line switch to...
du * | xdiskusage leads do segfault
Attempt to fix this in the git repository now.
buffer issue on lubuntu
Fixed with int x = (int)(long)(pointer) instead.