#4555 lsslp -s PBMC does not honor -n flag

[Ling]

Customer reports that -n flag is not honored for lsslp for P8 LE.
lsslp -s PBMC -w
It discovered 5 servers. The customer changed the names of the severs. Then removed 1 server from xCAT DB, then run the the following command:
lsslp -s PBMC -w -n
The command put all 5 servers in the xCAT DB instead of the one that was removed.

[Ling]

The function with -n should check against the ip address and only puts the new ones in.

[irrogical]

The list of nodes found by lsslp:

xcat@mn-4:~$ lsslp -s PBMC
Sending SLP request on interfaces: 10.64.0.1,10.192.0.1,192.168.122.1,10.0.0.1 ...
Received 8 responses.
Sending SLP request on interfaces: 10.64.0.1,10.192.0.1,192.168.122.1,10.0.0.1 ...
Received 0 responses.
Sending SLP request on interfaces: 10.64.0.1,10.192.0.1,192.168.122.1,10.0.0.1 ...
Received 0 responses.
Sending SLP request on interfaces: 10.64.0.1,10.192.0.1,192.168.122.1,10.0.0.1 ...
Received 0 responses.
4 requests with 8 responses.  Now processing responses.  This will take 0-1 minutes...
device  type-model  serial-number  side  ip-addresses  hostname
pbmc    8247-22L    2126F1A              10.0.0.34     Server-8247-22L-SN2126F1A
pbmc    8247-22L    2126F2A              10.0.0.32     Server-8247-22L-SN2126F2A
pbmc    8247-22L    2126F3A              10.0.0.33     Server-8247-22L-SN2126F3A
pbmc    8247-22L    2126F4A              10.0.0.35     Server-8247-22L-SN2126F4A

xcat@mn-4:~$

The nodes already known to xCAT:

xcat@mn-4:~$ nodels
cn006-mgmt
cn007-mgmt
cn008-mgmt
xcat@mn-4:~$ lsdef -t node cn006-mgmt
Object name: cn006-mgmt
    bmc=10.0.0.35
    cons=ipmi
    groups=pbmc,all
    hidden=0
    mgt=ipmi
    mtm=8247-22L
    nodetype=ppc
    postbootscripts=otherpkgs
    postscripts=syslog,remoteshell,syncfiles
    serial=2126F4A
xcat@mn-4:~$

All the cn00[678] nodes are similar, and were added to the node table via lsslp -w. I have added another node to my cluster, Server-8247-22L-SN2126F3A, which I will rename to cn005-mgmt. I would expect lsslp -w will notice that the Serial, MTM, and IP address of 3 nodes are already present, and skip those during the database update process. However,

running lsslp -s PBMC -w -V

xcat@mn-4:~$ lsslp -s PBMC -w -V
13:45:25 66627
--------  Wed Feb  4 13:45:25 2015
Time     PID
Sending SLP request on interfaces: 192.168.122.1,10.0.0.1,10.64.0.1,10.192.0.1 ...
Received 8 responses.
Sending SLP request on interfaces: 192.168.122.1,10.0.0.1,10.64.0.1,10.192.0.1 ...
Received 0 responses.
Sending SLP request on interfaces: 192.168.122.1,10.0.0.1,10.64.0.1,10.192.0.1 ...
Received 0 responses.
Sending SLP request on interfaces: 192.168.122.1,10.0.0.1,10.64.0.1,10.192.0.1 ...
Received 0 responses.
13:45:31 66627 Total SLP Time: 5.764 sec

4 requests with 8 responses.  Now processing responses.  This will take 0-1 minutes...
13:45:31 66627 Now lsslp begin to parse its response...
13:45:31 66627


Begin to find find frame's hostname
13:45:31 66627


Begin to find cec's parent
13:45:31 66627


Begin to find cec hostname
13:45:31 66627


Begin to find fsp/bpa's hostname and parent
13:45:31 66627


Begin to adjust fsp/bpa's id
13:45:31 66627


Begin to find cmm hostname in switch table
Begin to write into Database, this may change node name
device  type-model  serial-number  side  ip-addresses  hostname
pbmc    8247-22L    2126F1A              10.0.0.34     Server-8247-22L-SN2126F1A
pbmc    8247-22L    2126F2A              10.0.0.32     Server-8247-22L-SN2126F2A
pbmc    8247-22L    2126F3A              10.0.0.33     Server-8247-22L-SN2126F3A
pbmc    8247-22L    2126F4A              10.0.0.35     Server-8247-22L-SN2126F4A

xcat@mn-4:~$ nodels
Server-8247-22L-SN2126F1A
Server-8247-22L-SN2126F2A
Server-8247-22L-SN2126F3A
Server-8247-22L-SN2126F4A
cn006-mgmt
cn007-mgmt
cn008-mgmt
xcat@mn-4:~$

the node database has the original 3 nodes re-inserted with their original display names.

xcat@mn-4:~$ lsdef -t node cn006-mgmt
Object name: cn006-mgmt
    bmc=10.0.0.35
    cons=ipmi
    groups=pbmc,all
    hidden=0
    mgt=ipmi
    mtm=8247-22L
    nodetype=ppc
    postbootscripts=otherpkgs
    postscripts=syslog,remoteshell,syncfiles
    serial=2126F4A
xcat@mn-4:~$ lsdef -t node Server-8247-22L-SN2126F4A
Object name: Server-8247-22L-SN2126F4A
    bmc=10.0.0.35
    groups=pbmc,all
    hidden=0
    mgt=ipmi
    mtm=8247-22L
    nodetype=ppc
    postbootscripts=otherpkgs
    postscripts=syslog,remoteshell,syncfiles
    serial=2126F4A

[Guang Cheng Li]

Er Tao, could you work on this bug? Thanks.

[zhao er tao]

Fixed this defect with git commit hash num 4dd21f177578050491127cbb2e3762a39f125910 for master and 156840fc28fa072dac307a3a617f34373016c516 for 2.9

[zhao er tao]

Haven't update nodetype attribute for predefined node after discovery process. Checked in code with git commit hash num fd1734478cfaea88a42f96ac9fbc123c1b1552cc for 2.9 and f84470119831c157379af74a3d4f43f48d99dcd5 for master.