#3985 site.sharedtftp not operating as documented for hostname

[Russell]

When setting site.sharedtftp to a hostname, it is not being treated like sharedtftp = 1. Service nodes appear to still be attempting to write out their own files under /tftpboot. Nodesets are being repeated on each service node.

[Lissa Valletta]

Could you give us this output

tabdump site | grep sharedtftp

[Lissa Valletta]

Guang Cheng, we have a common check in our code, code like this
if ($sent and ($sent->{value} == 0 or $sent->{value} =~ /no/i)) {

I can only get this to fail if sharedtftp=yes or 1

If you code hostnames like sharedtftp=node0 it evaluates true. I guess all the places we have this check need to be change

main::(AAsndriver.db2:27): my $sent = $stab->getAttribs({key=>'sharedtftp'},'value');
DB<1> n
main::(AAsndriver.db2:28): if ($sent and ($sent->{value} == 0 or $sent->{value} =~ /no/i)) {
DB<1> n
main::(AAsndriver.db2:29): my $rc=1;
DB<1> n
DB<1> x $sent
0 HASH(0x1003eba0060)
'value' => 'node0'

[Lissa Valletta]

This new check will probably suffice
if ($sent and ($sent->{value} eq "0" or $sent->{value} =~ "no" or $sent->{value} =~ "NO")) {

[Lissa Valletta]

2.9 commit 4c031e18061b70b9ba75f8e03fb41cb8d75ddc22
2.8.4 fix commit dad84f2d1a37d398c55ab85ac64f61bdbe609b72