#3946 [DEV] restarting xcatd on rhels5.10 complains "Restarting xCATd Unrecognized escape \h passed through at /opt/xcat/lib/perl/xCAT/zvmUtils.pm line 2396.."

[yangsong]

[root@p7hv16sbbr02 postscripts]# service xcatd restart
Restarting xCATd Unrecognized escape \h passed through at /opt/xcat/lib/perl/xCAT/zvmUtils.pm line 2396.
[ OK ]

[root@p7hv16sbbr02 ~]# lsxcatd -v
Version 2.8.3 (built Tue Nov 12 23:16:15 EST 2013)
[root@p7hv16sbbr02 ~]# rpm -qa|grep perl
perl-String-CRC32-1.4-2.fc6
net-snmp-perl-5.3.2.2-20.el5
perl-Expect-1.21-1
perl-HTML-Tagset-3.10-2.1.1
perl-XML-LibXML-Common-0.13-8.2.2
perl-Digest-SHA1-2.11-1.2.1
perl-XML-Parser-2.34-6.1.2.2.1
perl-5.8.8-41.el5
perl-DBI-1.52-2.el5
perl-IO-Tty-1.07-1
perl-IO-Socket-SSL-1.01-2.el5
perl-URI-1.35-3
perl-XML-SAX-0.14-13.el5
perl-IO-Stty-.02-1
perl-Net-Telnet-3.03-5.1
perl-DBD-SQLite-1.14-1
perl-XML-LibXML-1.58-6
perl-Digest-HMAC-1.01-15
perl-Net-DNS-0.59-3.el5
perl-XML-Simple-2.14-4.fc6
perl-xCAT-2.8.3-snap201311122316
perl-Net-SSLeay-1.30-4.fc6
perl-XML-NamespaceSupport-1.09-1.2.1
perl-Net-IP-1.25-2.fc6
perl-HTML-Parser-3.55-1.fc6
perl-Compress-Zlib-1.42-1.fc6
perl-Crypt-SSLeay-0.51-11.el5
perl-libwww-perl-5.805-1.1.1
[root@p7hv16sbbr02 ~]# cat /etc/*release
Red Hat Enterprise Linux Server release 5.10 (Tikanga)
[root@p7hv16sbbr02 ~]# uname -a
Linux p7hv16sbbr02 2.6.18-371.el5 #1 SMP Thu Sep 5 21:17:43 EDT 2013 ppc64 ppc64 ppc64 GNU/Linux
[root@p7hv16sbbr02 ~]#

[Lissa Valletta]

Chuck this looks like the code does affect Linux, so maybe we need to come up with a different expression that is more commonly acceptable.

This is the offending line:

$out =~ s/\h+/ /g;

IN this clause
if ($master eq $ip) {
# If the master IP and node IP match, then it is the management node
my $out = $sudo /bin/df -h /install | sed 1d;
$out =~ s/\h+/ /g;
my @results = split(' ', $out);
if ( $results[3] eq "0" ) {
$results[3] = "0M";
}
return $results[3];

The question is why are you seeing the error only now. This code is in 2.8.2, just checked. I thought we have been testing rh5.10 all along.

[Lissa Valletta]

The other question, why are we testing with 2.8.3 in this environment. Is there a reason we are not using 2.8.4?

[Chuckie]

I commented out that line on zLinux and the code still picks up the available space value in $results[3]. It seems odd to me that a valid escape character for horizontal whitespace is causing trouble. I have a lot of other changes to upgrade the sourceforge xCAT to be at a similar level as supplied in zVM 6.3, so I will put this change in with those.

[Lissa Valletta]

We need this fixed in 2.8.4, the customers are starting to hit it.

[Chuckie]

OK, I put this in the 2.8 git branch.

[Lissa Valletta]

Does this mean it is checked in? It also should be checked in the master branch and please run git log and give us the commit number for each branch and add to the defect. When checked in you should set the status to pending so FVT will know it can test on the next build.

[Lissa Valletta]

Yang Song please verify.

[Lissa Valletta]

Chuck I do not see this is fixed. Even on AIX I still get

unrecognized escape \h passed through at /opt/xcat/lib/perl/xCAT/zvmUtils.pm line 2408

This is the line that does not work and you do not appear to have changed it.
$out =~ s/\h+/ /g;

Please also make sure you fix 2.8 and the master branch ( 2.9).

[Chuckie]

Ah drat, I committed the changes to 2.8, forgot Master, then forgot to push them! Sorry

[Guang Cheng Li]

Seems the problem has been fixed in both 2.8 and 2.9.

2.8: 82715fac090e0b234a542d6112f21b5762e1172f
2.9: 1ece21a021b5bc128b24238d24f0e2e306b45439

[root@ls21n01 xcat-core]# git branch
2.6

• 2.8
  2.8.2-pcm
  master
  [root@ls21n01 xcat-core]# git show 82715fac090e0b234a542d6112f21b5762e1172f
  commit 82715fac090e0b234a542d6112f21b5762e1172f
  Author: Chuck Brazie cbrazie@stny.rr.com
  Date: Wed Jan 15 07:49:29 2014 -0500

  Comment out \ h escape character

diff --git a/perl-xCAT/xCAT/zvmUtils.pm b/perl-xCAT/xCAT/zvmUtils.pm
index b37f84c..03b99b5 100644
--- a/perl-xCAT/xCAT/zvmUtils.pm
+++ b/perl-xCAT/xCAT/zvmUtils.pm
@@ -2405,7 +2405,7 @@ sub getFreeRepoSpace {
if ($master eq $ip) {
# If the master IP and node IP match, then it is the management node
my $out = $sudo /bin/df -h /install | sed 1d;

• $out =~ s/\h+/ /g;

• causing problems on other platforma $out =~ s/\h+/ /g;

   my @results = split(' ', $out);
   if ( $results[3] eq "0" ) {
       $results[3] = "0M";
  

  [root@ls21n01 xcat-core]# git checkout master
  Switched to branch 'master'
  [root@ls21n01 xcat-core]# git show 1ece21a021b5bc128b24238d24f0e2e306b45439
  commit 1ece21a021b5bc128b24238d24f0e2e306b45439
  Author: Chuck Brazie cbrazie@stny.rr.com
  Date: Tue Apr 1 13:23:24 2014 -0400

  Comment out the horizontal whitespace escape char

diff --git a/perl-xCAT/xCAT/zvmUtils.pm b/perl-xCAT/xCAT/zvmUtils.pm
index d18008a..f8de180 100644
--- a/perl-xCAT/xCAT/zvmUtils.pm
+++ b/perl-xCAT/xCAT/zvmUtils.pm
@@ -2393,7 +2393,7 @@ sub getFreeRepoSpace {
if ($master eq $ip) {
# If the master IP and node IP match, then it is the management node
my $out = $sudo /bin/df -h /install | sed 1d;

• $out =~ s/\h+/ /g;

• causing problems on other platforms $out =~ s/\h+/ /g;$out =~ s/\h+/ /g;

   my @results = split(' ', $out);
   return ($results[3]);
  

  }
  [root@ls21n01 xcat-core]#