#3847 [FVT]buildkit addpkgs -k -r left useless kit component rpm in complete kit repos dir

[BaiYuan]

After executing buildkit addpkgs pperte-1.3.0.6-0-x86_64.NEED_PRODUCT_PKGS.tar.bz2 --pkgdir /baiyuan/0918/tmp/pperte1.3.0.6/,tmp/src -k 1.3.0.6 -r s006a,there are 2 useless directory pperte-1.3.0.6-0-rhels-6-x86_64 and pperte-1.3.0.6-0-sles-11-x86_64 left in compete kit repos directory.

reproduce steps:
[root@rhmn 0918]# buildkit addpkgs pperte-1.3.0.6-0-x86_64.NEED_PRODUCT_PKGS.tar.bz2 --pkgdir /baiyuan/0918/tmp/pperte1.3.0.6/,tmp/src -k 1.3.0.6 -r s006a
Extracting tar file /baiyuan/0918/pperte-1.3.0.6-0-x86_64.NEED_PRODUCT_PKGS.tar.bz2.
Spawning worker 0 with 13 pkgs
Workers Finished
Gathering worker results
... .....
Generating sqlite DBs
Sqlite DBs complete
Creating tar file /tmp/pperte-1.3.0.6-0-x86_64/pperte-1.3.0.6-s006a-x86_64/pperte-1.3.0.6-s006a-x86_64.tar.bz2.
Kit tar file /baiyuan/0918/pperte-1.3.0.6-s006a-x86_64.tar.bz2 successfully built.

[root@rhmn 0918]# tar -jxvf /baiyuan/0918/pperte-1.3.0.6-s006a-x86_64.tar.bz2
.....

[root@rhmn 0918]# cd pperte-1.3.0.6-s006a-x86_64/repos/
[root@rhmn repos]# ls -l
total 16
drwxr-sr-x 3 root root 4096 Aug 16 03:54 pperte-1.3.0.6-0-rhels-6-x86_64 ------useless
drwxr-sr-x 3 root root 4096 Aug 16 03:54 pperte-1.3.0.6-0-sles-11-x86_64 ------useless
drwxr-sr-x 3 root root 4096 Oct 23 04:27 pperte-1.3.0.6-s006a-rhels-6-x86_64 -----useful
drwxr-sr-x 3 root root 4096 Oct 23 04:27 pperte-1.3.0.6-s006a-sles-11-x86_64 -----useful

[root@rhmn repos]# cd pperte-1.3.0.6-0-rhels-6-x86_64
[root@rhmn pperte-1.3.0.6-0-rhels-6-x86_64]# ls
min_pperte_compute-1.3.0.6-0.noarch.rpm pperte_license-1.3.0.6-0.noarch.rpm prep_pperte_license-1.3.0.6-0.noarch.rpm
pperte_compute-1.3.0.6-0.noarch.rpm pperte_login-1.3.0.6-0.noarch.rpm repodata

[root@rhmn pperte-1.3.0.6-0-rhels-6-x86_64]# cd ../pperte-1.3.0.6-0-sles-11-x86_64
[root@rhmn pperte-1.3.0.6-0-sles-11-x86_64]# ls
min_pperte_compute-1.3.0.6-0.noarch.rpm pperte_license-1.3.0.6-0.noarch.rpm prep_pperte_license-1.3.0.6-0.noarch.rpm
pperte_compute-1.3.0.6-0.noarch.rpm pperte_login-1.3.0.6-0.noarch.rpm repodata

[root@rhmn pperte-1.3.0.6-0-sles-11-x86_64]# cd ../pperte-1.3.0.6-s006a-rhels-6-x86_64
[root@rhmn pperte-1.3.0.6-s006a-rhels-6-x86_64]# ls
min_pperte_compute-1.3.0.6-s006a.noarch.rpm ppe_rte_samples-1.3.0.6-s006a.x86_64.rpm pperte_login-1.3.0.6-s006a.noarch.rpm repodata
ppe_rte_1306-1.3.0.6-s006a.x86_64.rpm pperte-1.3.0.6-s006a.x86_64.rpm pperteman-1.3.0.6-s006a.x86_64.rpm src-1.3.1.1-12080.i386.rpm
ppe_rte_license-1.3.0.0-1302a.x86_64.rpm pperte_compute-1.3.0.6-s006a.noarch.rpm ppertesamples-1.3.0.6-s006a.x86_64.rpm
ppe_rte_man-1.3.0.6-s006a.x86_64.rpm pperte_license-1.3.0.6-s006a.noarch.rpm prep_pperte_license-1.3.0.6-s006a.noarch.rpm

[root@rhmn pperte-1.3.0.6-s006a-rhels-6-x86_64]# cd ../pperte-1.3.0.6-s006a-sles-11-x86_64
[root@rhmn pperte-1.3.0.6-s006a-sles-11-x86_64]# ls
min_pperte_compute-1.3.0.6-s006a.noarch.rpm ppe_rte_samples-1.3.0.6-s006a.x86_64.rpm pperte_login-1.3.0.6-s006a.noarch.rpm repodata
ppe_rte_1306-1.3.0.6-s006a.x86_64.rpm pperte-1.3.0.6-s006a.x86_64.rpm pperteman-1.3.0.6-s006a.x86_64.rpm src-1.3.1.1-12080.i386.rpm
ppe_rte_license-1.3.0.0-1302a.x86_64.rpm pperte_compute-1.3.0.6-s006a.noarch.rpm ppertesamples-1.3.0.6-s006a.x86_64.rpm
ppe_rte_man-1.3.0.6-s006a.x86_64.rpm pperte_license-1.3.0.6-s006a.noarch.rpm prep_pperte_license-1.3.0.6-s006a.noarch.rpm

[Norm Nott]

[Norm Nott]

I get the same result.

Just to be clear - the only issue here is that there seem to be some directories created that have no use - correct?

I'll have to crawl through the code to see what is going on.

[Norm Nott]

It seems these old repos dirs are the kit component rpms from the original partial kit. They can probably be removed.

The code to remove them will have to be smart enough not to remove someting that we really need.

This probably should be moved to the next xCAT release since it's not critical.

However, since these really don't cause any harm, maybe it's not worth the effort to remove them? They shouldn't take up much space.

Please either move this to 2.8.4 or close it. Thanks

[Norm Nott]

[BaiYuan]

According to Norm comments,since it's not critical,move it to 2.8.4.

[BaiYuan]

Agree with Norm,the code to remove them will have to be smart enough not to remove something that we really need, move it to 2.9.

[BaiYuan]

fixed in 2.9;
commit dff4cad29f8d3465638a52083b5001ec3074beff