#2911 PMR 19420:rflash for FSP has a syntax error in FSPrflash.pm

2.7.3
closed
8
2012-10-19
2012-05-30
No

There are two synatx errors in FSPflash.pm causing it to not be able to be executed. Here are the two erros that were found.

1) line 150 didn't have the matching ")"
2) line 335 "} elsif (exists($activate)){" - is getting an error about the varaible not being a hash. I think this should just be an empty else with no check to default to the error message following.

Please correct the syntax errors at a minimum and place the update verison n this defect for a work around to this problem.

Discussion

  • Brian  Croswell

    Brian Croswell - 2012-05-30

    Execution of rflash has syntax issues on xCAT 2.7.2 5/23 GA buld ..
    Please use xCAT P7 IH cluster to clear up syntax issues ..

    [c250mgrs33-pvt][/]> rflash f17c02 -v
    syntax error at /opt/xcat/lib/perl/xCAT/FSPflash.pm line 150, near "/^(disruptive|deferred)$/ {"
    Global symbol "$filename" requires explicit package name at /opt/xcat/lib/perl/xCAT/FSPflash.pm line 157.
    Global symbol "$filename" requires explicit package name at /opt/xcat/lib/perl/xCAT/FSPflash.pm line 161.
    Global symbol "$msg" requires explicit package name at /opt/xcat/lib/perl/xCAT/FSPflash.pm line 162.
    Global symbol "$filename" requires explicit package name at /opt/xcat/lib/perl/xCAT/FSPflash.pm line 162.
    Global symbol "$msg" requires explicit package name at /opt/xcat/lib/perl/xCAT/FSPflash.pm line 163.
    Global symbol "$filename" requires explicit package name at /opt/xcat/lib/perl/xCAT/FSPflash.pm line 166.
    Global symbol "$upgrade_required" requires explicit package name at /opt/xcat/lib/perl/xCAT/FSPflash.pm line 166.
    Global symbol "$msg" requires explicit package name at /opt/xcat/lib/perl/xCAT/FSPflash.pm line 166.
    syntax error at /opt/xcat/lib/perl/xCAT/FSPflash.pm line 168, near "}"
    /opt/xcat/lib/perl/xCAT/FSPflash.pm has too many errors.
    Compilation failed in require at (eval 52) line 3.

     
  • Brian  Croswell

    Brian Croswell - 2012-05-30

    Since this is an issue FSPflash.pm it also affects the rflash testing with NGP firebird blades also . I validated the rflash syntax error is also found on my NGP firebird cluster.

     
  • zhao er tao

    zhao er tao - 2012-05-31
     
  • zhao er tao

    zhao er tao - 2012-05-31

    I had fixed this bug with xcat2.7 revision 12968 and attached the e-fix. I hadn't covered this issue when doing UT.

     
  • Brian  Croswell

    Brian Croswell - 2012-05-31

    This xCAT bug with rflash only affects System P hardware that interacts with BPA and fsp mgt interfaces that work with DFM. This includes the hardware working
    with P775 (P7 IH) and Pureflex (NGP) firebird blades.

    This bug does not affect any System X or System P hmc mgt environments.

     
  • Lissa Valletta

    Lissa Valletta - 2012-06-01

    To apply the FSPflash.pm file attached below, on the Management Node (EMS) only
    cd /opt/xcat/lib/perl/xCAT
    cp FSPflash.pm FSPflash.pm.bad
    copy the attached FSPflash.pm to /opt/xcat/lib/perl/xCAT/FSPflash.pm
    on Linux:
    service xcatd restart
    On AIX
    restartxcatd

     
  • John Simpson

    John Simpson - 2012-06-07

    This defect is fixed in PMR 19420. For xCAT adminstrators looking for the official AIX ifix contact IBM customer service for this PMR in the zaix,13a queue. The ifix can be downloaded from the ftp testcase.software.ibm.com download site. Note that the ifix it only remains on this download site for 5-7 days.

     
  • John Simpson

    John Simpson - 2012-06-13

    AIX ifix for this defect - unzip and follow readme instructions

     
  • John Simpson

    John Simpson - 2012-06-13

    The AIX ifix for this defect has been attached. Download an unzip the file. Here are the README instructions:
    This is the README for sourceforge defect 3530839

    This ifix needs to only be installed on the EMS.

    1) emgr -e SF3530839.120601.epkg.Z
    2) recycle the xcat daemon
    a) stopsrc -s xcatd
    b) startsrc -s xcatd

    To uninstall
    1) emgr -r -L SF3530839
    2) recycle the xcat daemon
    a) stopsrc -s xcatd
    b) startsrc -s xcatd

     
  • Lissa Valletta

    Lissa Valletta - 2012-08-17

    This is fixed in 2.7.3 and later

     
  • Lissa Valletta

    Lissa Valletta - 2012-10-19
    • status: pending --> closed
     
  • Lissa Valletta

    Lissa Valletta - 2012-10-19

    Checked with service it is closed