Menu
▾
▴
xc3sprog-users
|
From: Uffe J. <uf...@uf...> - 2015-05-24 19:11:19
|
Hello, First of all thanks for a quite useful utility I'm sorry to write this - but the coding style of xc3sprog is quite messy. Lots of the src files have: different indentation (mixed spaces and tabs) and different bracing style etc... What is the "official" coding style for xc3sprog contributions ? Would you accept patches that fixed the xc3sprog source to a common style ? Thanks in advance Kind regards Uffe Jakobsen |
|
From: Uwe B. <bo...@el...> - 2015-05-27 09:18:46
|
>>>>> "Uffe" == Uffe Jakobsen <uf...@uf...> writes:
Uffe> Hello,
Uffe> First of all thanks for a quite useful utility
Uffe> I'm sorry to write this - but the coding style of xc3sprog is
Uffe> quite messy.
I fully agree.
Uffe> Lots of the src files have: different indentation (mixed spaces
Uffe> and tabs) and different bracing style etc...
Uffe> What is the "official" coding style for xc3sprog contributions ?
There is no "official" coding style yet.
Uffe> Would you accept patches that fixed the xc3sprog source to a
Uffe> common style ?
If we can aggree on a coding style and if clean-up and other work is
strictly decoupled I will gladly do. Do you already have project admin
access on sourceforge?
I do much work on Nut O/S now. Can you have a look at
http://www.ethernut.de/en/documents/programming-style-guide.html ?
Beside the restriction caused by the many arch NutOS has to bear with, I now
try to follow the NutOS style.
If you want, I can send you my .git repository of sourceforge SVN. I locally
work with git-svn. Branching is easy with git/svn.
Cheers
--
Uwe Bonnes bo...@el...
Institut fuer Kernphysik Schlossgartenstrasse 9 64289 Darmstadt
--------- Tel. 06151 162516 -------- Fax. 06151 164321 ----------
|
|
From: Uffe J. <uf...@uf...> - 2015-05-29 22:57:25
|
Hi Uwe, Thanks for your reply On 2015-05-27 11:18, Uwe Bonnes wrote: >>>>>> "Uffe" == Uffe Jakobsen <uf...@uf...> writes: > > Uffe> Hello, > > Uffe> First of all thanks for a quite useful utility > > Uffe> I'm sorry to write this - but the coding style of xc3sprog is > Uffe> quite messy. > > I fully agree. > > Uffe> Lots of the src files have: different indentation (mixed spaces > Uffe> and tabs) and different bracing style etc... > > Uffe> What is the "official" coding style for xc3sprog contributions ? > > There is no "official" coding style yet. > > Uffe> Would you accept patches that fixed the xc3sprog source to a > Uffe> common style ? > > If we can aggree on a coding style and if clean-up and other work is > strictly decoupled I will gladly do. Do you already have project admin > access on sourceforge? Sure - agree, clean-up and other work should not be mixed. My idea was to break the clean-up into a couple of "transactions" (commits). Each of these transactions dealing with a separate issue - eg indentation, bracing etc. The reason for this approach is that the number of changes will be quite big for each of these changes - and fixing one thing at a time would be easier to review (I think). My sourceforge prj-user is "uffejakobsen" > > I do much work on Nut O/S now. Can you have a look at > http://www.ethernut.de/en/documents/programming-style-guide.html ? > Did a quick scan of the style guide - looks ok to me :-) > Beside the restriction caused by the many arch NutOS has to bear with, I now > try to follow the NutOS style. > > If you want, I can send you my .git repository of sourceforge SVN. I locally > work with git-svn. Branching is easy with git/svn. > That would be great. I started my clean-up work on a svn extract - and missed the local branching features of git - so I also did an git/svn clone :-) Does this mean that you have changes locally that are now yet pushed to sourceforge svn ? Kind regards Uffe |
|
From: Sidney C. <si...@ji...> - 2015-05-31 16:18:15
|
On a related note, wouldn't this be a good time to transfer xc3sprog to github altogether? Regards, Sidney |
|
From: Sidney C. <si...@ji...> - 2015-06-01 10:40:58
|
Hi Uwe:
> Can you give any reasons for this request?
Sure,
- github is technically preferrable to SourceForge;
- git is superior to svn;
- SourceForge has descended into very nasty business practices:
http://blog.gluster.org/2013/08/how-far-the-once-mighty-sourceforge-has-fallen/
Therefore, if somebody is offering to work on a big code cleanup
(which is very good), I think this may be a good time to switch over.
Cheerio,
Sidney
|
|
From: Uwe B. <bo...@el...> - 2015-06-01 10:54:31
|
>>>>> "Sidney" == Sidney Cadot <si...@ji...> writes:
Sidney> Hi Uwe:
>> Can you give any reasons for this request?
Sidney> Sure,
Sidney> - github is technically preferrable to SourceForge; - git is
Sidney> superior to svn; - SourceForge has descended into very nasty
Sidney> business practices:
Sidney> http://blog.gluster.org/2013/08/how-far-the-once-mighty-sourceforge-has-fallen/
Sidney> Therefore, if somebody is offering to work on a big code cleanup
Sidney> (which is very good), I think this may be a good time to switch
Sidney> over.
Any opinions from other readers?
--
Uwe Bonnes bo...@el...
Institut fuer Kernphysik Schlossgartenstrasse 9 64289 Darmstadt
--------- Tel. 06151 162516 -------- Fax. 06151 164321 ----------
|
|
From: Sébastien B. <sb...@m-...> - 2015-06-01 11:12:58
|
On 06/01/2015 06:54 PM, Uwe Bonnes wrote: > Any opinions from other readers? I agree with those reasons. |
|
From: Uffe J. <uf...@uf...> - 2015-06-01 21:26:00
|
On 2015-06-01 12:54, Uwe Bonnes wrote: > > Any opinions from other readers? > I was actually going to suggest the same - I just didn't want to put too many topics into one thread /Uffe |
|
From: Uffe J. <uf...@uf...> - 2015-06-02 21:25:16
|
On 2015-06-02 10:46, Uwe Bonnes wrote: >>>>>> "Uffe" == Uffe Jakobsen <uf...@uf...> writes: > > Uffe> On 2015-06-01 12:54, Uwe Bonnes wrote: > >> > >> Any opinions from other readers? > >> > > Uffe> I was actually going to suggest the same - I just didn't want to > Uffe> put too many topics into one thread > > So there are 3 voice for a move and one against. > > I will let the subject hanging for some time, so perhaps other contributors > may raise their voice. > Even though I like github more than sourceforge - it is definately not a mandatory thing for me. Fixing the code style is my main priority. /Uffe |
Thanks for helping keep SourceForge clean.
X