Re: [Xc3sprog-users] Coding style for xc3sprog

[Uffe J. <uf...@uf...>]

Hi Uwe,

Thanks for your reply

On 2015-05-27 11:18, Uwe Bonnes wrote:
>>>>>> "Uffe" == Uffe Jakobsen <uf...@uf...> writes:
>
>      Uffe> Hello,
>
>      Uffe> First of all thanks for a quite useful utility
>
>      Uffe> I'm sorry to write this - but the coding style of xc3sprog is
>      Uffe> quite messy.
>
> I fully agree.
>
>      Uffe> Lots of the src files have: different indentation (mixed spaces
>      Uffe> and tabs) and different bracing style etc...
>
>      Uffe> What is the "official" coding style for xc3sprog contributions ?
>
> There is no "official" coding style yet.
>
>      Uffe> Would you accept patches that fixed the xc3sprog source to a
>      Uffe> common style ?
>
> If we can aggree on a coding style and if clean-up and other work is
> strictly decoupled I will gladly do. Do you already have project admin
> access on sourceforge?

Sure - agree, clean-up and other work should not be mixed.

My idea was to break the clean-up into a couple of "transactions" (commits).
Each of these transactions dealing with a separate issue - eg 
indentation, bracing etc.
The reason for this approach is that the number of changes will be quite 
big for each of these changes - and fixing one thing at a time would be 
easier to review (I think).

My sourceforge prj-user is "uffejakobsen"

>
> I do much work on Nut O/S now. Can you have a look at
> http://www.ethernut.de/en/documents/programming-style-guide.html ?
>

Did a quick scan of the style guide - looks ok to me :-)

> Beside the restriction caused by the many arch NutOS has to bear with, I now
> try to follow the NutOS style.
>
> If you want, I can send you my .git repository of sourceforge SVN. I locally
> work with git-svn. Branching is easy with git/svn.
>

That would be great.

I started my clean-up work on a svn extract - and missed the local 
branching features of git - so I also did an git/svn clone  :-)

Does this mean that you have changes locally that are now yet pushed to 
sourceforge svn ?

Kind regards Uffe