Re: [Xbgtk-list] [Harbour] Build xhgtk inside harbour

[Przemyslaw C. <dr...@ac...>]

On Fri, 13 Mar 2009, Phil Krylov wrote:

Hi,

> > I have a patch for Harbour builds and some small cleanups to
> > the version in CVS.
> > Can I sent it to you?
> Yes of course, probably the xbgtk mailing list is a better place,
> AFAIR you were subscribed to it, but you can send the patch directly
> to me.

Here are modifications:

  * xbgtk/Makefile.config-simple
    * changed curses to ncurses - only SunOS [x]Harbour builds uses curses
      automake should also be updated. Probably the references to [n]curses,
      slang, gpm should be removed from current builds because now
      [x]harbour shared libraries are linked with bindings to external
      libraries

  * xbgtk/examples/xbgtk_demo/appwindow.prg
    * use hb_bitand() instead of numand(). hb_bit*() functions are default
      part of Harbour and xHarbour builds

  * xbgtk/include/xbgtk.h
    * updated xb_item* macros to current [x]Harbour API functions
    * enabled GC pointer items in Harbour builds

  * xbgtk/source/libglade_xb.override
    * enabled hash item support in Harbour builds
    % minor optimization

  * xbgtk/source/xbadd.c
    * enabled hash item support in Harbour builds
    ! fixed typo in variable name 'item' variable is used internally
      in HPARAM() macro what may cause very bad results in code like:
         PHB_ITEM item = HPARAM(n);

After each
   make distclean
if I also remove manually:
   xbgtk/source/genheader_atk
   xbgtk/source/genheader_gdk
   xbgtk/source/genheader_gtk
   xbgtk/source/genheader_pango
   xbgtk/source/genheader_xbgtk-fundamental
   xbgtk/source/xbgtk-fundamental.ch

I see this error:
   make[1]: *** No rules to make target object `genheader_atk', necessary for `atk.ch'. Stop.

the next make calls works correctly. It should be fixed.

I think that you should look also at this warnings:
   gtk.prg:7698: warning: passing argument 2 of 'gtk_about_dialog_set_authors' from incompatible pointer type
   gtk.prg:7729: warning: passing argument 2 of 'gtk_about_dialog_set_documenters' from incompatible pointer type
   gtk.prg:7760: warning: passing argument 2 of 'gtk_about_dialog_set_artists' from incompatible pointer type
   gtk.prg:38561: warning: assignment from incompatible pointer type
   pango.prg:1850: warning: assignment discards qualifiers from pointer target type
   pango.prg:2502: warning: assignment makes pointer from integer without a cast
In most of cases const is missing in declaration.

best regards,
Przemek