#21 fails to build with GCC 10 due -fno-common being used now

[Dan Horak]

GCC 10 switched the default for the -fcommon option (see https://gcc.gnu.org/gcc-10/porting_to.html#common for details) and x3270 suite fails to build now. The behaviour can be reproduced by add -fno-common to CCOPTIONS.

It fails with message like these (see logs at https://koji.fedoraproject.org/koji/taskinfo?taskID=41325257 for all details)

...
rm -f xversion.c
gcc -o c3270 c3270.o ft_gui.o help.o icmd.o keymap.o keypad.o menubar.o screen.o ssl_passwd_gui.o fallbacks.o version.o -Wl,-z,relro -Wl,--as-needed  -Wl,-z,now -specs=/usr/lib/rpm/redhat/redhat-hardened-ld -L../../../obj/x86_64-redhat-linux-gnu/lib3270 -l3270 -L../../../obj/x86_64-redhat-linux-gnu/lib3270i -l3270i -L../../../obj/x86_64-redhat-linux-gnu/lib32xx -l32xx -lssl -lcrypto  -L../../../obj/x86_64-redhat-linux-gnu/lib3270stubs -l3270stubs -lreadline -lncursesw -lutil 
/usr/bin/ld: help.o:/builddir/build/BUILD/suite3270-3.6/obj/x86_64-redhat-linux-gnu/c3270/../../../include/glue.h:53: multiple definition of `Warning_redirect'; c3270.o:/builddir/build/BUILD/suite3270-3.6/obj/x86_64-redhat-linux-gnu/c3270/../../../include/glue.h:53: first defined here
/usr/bin/ld: help.o:/builddir/build/BUILD/suite3270-3.6/obj/x86_64-redhat-linux-gnu/c3270/../../../include/glue.h:52: multiple definition of `Error_redirect'; c3270.o:/builddir/build/BUILD/suite3270-3.6/obj/x86_64-redhat-linux-gnu/c3270/../../../include/glue.h:52: first defined here
/usr/bin/ld: keymap.o:/builddir/build/BUILD/suite3270-3.6/obj/x86_64-redhat-linux-gnu/c3270/../../../include/glue.h:53: multiple definition of `Warning_redirect'; c3270.o:/builddir/build/BUILD/suite3270-3.6/obj/x86_64-redhat-linux-gnu/c3270/../../../include/glue.h:53: first defined here
/usr/bin/ld: keymap.o:/builddir/build/BUILD/suite3270-3.6/obj/x86_64-redhat-linux-gnu/c3270/../../../include/glue.h:52: multiple definition of `Error_redirect'; c3270.o:/builddir/build/BUILD/suite3270-3.6/obj/x86_64-redhat-linux-gnu/c3270/../../../include/glue.h:52: first defined here
/usr/bin/ld: menubar.o:/builddir/build/BUILD/suite3270-3.6/obj/x86_64-redhat-linux-gnu/c3270/../../../include/glue.h:53: multiple definition of `Warning_redirect'; c3270.o:/builddir/build/BUILD/suite3270-3.6/obj/x86_64-redhat-linux-gnu/c3270/../../../include/glue.h:53: first defined here
/usr/bin/ld: menubar.o:/builddir/build/BUILD/suite3270-3.6/obj/x86_64-redhat-linux-gnu/c3270/../../../include/glue.h:52: multiple definition of `Error_redirect'; c3270.o:/builddir/build/BUILD/suite3270-3.6/obj/x86_64-redhat-linux-gnu/c3270/../../../include/glue.h:52: first defined here
/usr/bin/ld: screen.o:/builddir/build/BUILD/suite3270-3.6/obj/x86_64-redhat-linux-gnu/c3270/../../../include/glue.h:53: multiple definition of `Warning_redirect'; c3270.o:/builddir/build/BUILD/suite3270-3.6/obj/x86_64-redhat-linux-gnu/c3270/../../../include/glue.h:53: first defined here
/usr/bin/ld: screen.o:/builddir/build/BUILD/suite3270-3.6/obj/x86_64-redhat-linux-gnu/c3270/../../../include/glue.h:52: multiple definition of `Error_redirect'; c3270.o:/builddir/build/BUILD/suite3270-3.6/obj/x86_64-redhat-linux-gnu/c3270/../../../include/glue.h:52: first defined here
/usr/bin/ld: ../../../obj/x86_64-redhat-linux-gnu/lib3270/lib3270.a(XtGlue.o):/builddir/build/BUILD/suite3270-3.6/obj/x86_64-redhat-linux-gnu/lib3270/../../../include/glue.h:52: multiple definition of `Error_redirect'; c3270.o:/builddir/build/BUILD/suite3270-3.6/obj/x86_64-redhat-linux-gnu/c3270/../../../include/glue.h:52: first defined here
/usr/bin/ld: ../../../obj/x86_64-redhat-linux-gnu/lib3270/lib3270.a(XtGlue.o):/builddir/build/BUILD/suite3270-3.6/obj/x86_64-redhat-linux-gnu/lib3270/../../../include/glue.h:53: multiple definition of `Warning_redirect'; c3270.o:/builddir/build/BUILD/suite3270-3.6/obj/x86_64-redhat-linux-gnu/c3270/../../../include/glue.h:53: first defined here
/usr/bin/ld: ../../../obj/x86_64-redhat-linux-gnu/lib3270/lib3270.a(glue.o):/builddir/build/BUILD/suite3270-3.6/obj/x86_64-redhat-linux-gnu/lib3270/../../../include/glue.h:53: multiple definition of `Warning_redirect'; c3270.o:/builddir/build/BUILD/suite3270-3.6/obj/x86_64-redhat-linux-gnu/c3270/../../../include/glue.h:53: first defined here
/usr/bin/ld: ../../../obj/x86_64-redhat-linux-gnu/lib3270/lib3270.a(glue.o):/builddir/build/BUILD/suite3270-3.6/obj/x86_64-redhat-linux-gnu/lib3270/../../../include/glue.h:52: multiple definition of `Error_redirect'; c3270.o:/builddir/build/BUILD/suite3270-3.6/obj/x86_64-redhat-linux-gnu/c3270/../../../include/glue.h:52: first defined here
/usr/bin/ld: ../../../obj/x86_64-redhat-linux-gnu/lib3270/lib3270.a(readres.o):/builddir/build/BUILD/suite3270-3.6/obj/x86_64-redhat-linux-gnu/lib3270/../../../include/glue.h:53: multiple definition of `Warning_redirect'; c3270.o:/builddir/build/BUILD/suite3270-3.6/obj/x86_64-redhat-linux-gnu/c3270/../../../include/glue.h:53: first defined here
/usr/bin/ld: ../../../obj/x86_64-redhat-linux-gnu/lib3270/lib3270.a(readres.o):/builddir/build/BUILD/suite3270-3.6/obj/x86_64-redhat-linux-gnu/lib3270/../../../include/glue.h:52: multiple definition of `Error_redirect'; c3270.o:/builddir/build/BUILD/suite3270-3.6/obj/x86_64-redhat-linux-gnu/c3270/../../../include/glue.h:52: first defined here
collect2: error: ld returned 1 exit status
make[2]: *** [../../../c3270/Makefile.obj:80: c3270] Error 1
make[2]: Leaving directory '/builddir/build/BUILD/suite3270-3.6/obj/x86_64-redhat-linux-gnu/c3270'
make[1]: *** [Makefile:39: all] Error 2
make[1]: Leaving directory '/builddir/build/BUILD/suite3270-3.6/c3270'
make: *** [Makefile:118: c3270] Error 2

rm -f xversion.c
gcc -o x3270 Cme.o CmeBSB.o CmeLine.o CmplxMenu.o Husk.o about.o dialog.o display8.o display_charsets.o display_charsets_dbcs.o ft_gui.o host_gui.o idle_gui.o keymap.o keypad.o keysym2ucs.o menubar.o nvt_gui.o popups.o print_gui.o print_window.o printer_gui.o resources.o save.o screen.o select.o ssl_passwd_gui.o status.o stmenu.o trace_gui.o x3270.o xaa.o xactions.o xkybd.o xtables.o xutil.o fallbacks.o version.o -Wl,-z,relro -Wl,--as-needed  -Wl,-z,now -specs=/usr/lib/rpm/redhat/redhat-hardened-ld -L../../../obj/x86_64-redhat-linux-gnu/lib3270 -l3270 -L../../../obj/x86_64-redhat-linux-gnu/lib3270i -l3270i -L../../../obj/x86_64-redhat-linux-gnu/lib32xx -l32xx -lssl -lcrypto  -L../../../obj/x86_64-redhat-linux-gnu/lib3270stubs -l3270stubs -lXaw -lXmu -lXt -lX11 -lutil 
/usr/bin/ld: keymap.o:/builddir/build/BUILD/suite3270-3.6/obj/x86_64-redhat-linux-gnu/x3270/../../../x3270/xscreen.h:167: multiple definition of `font_count'; about.o:/builddir/build/BUILD/suite3270-3.6/obj/x86_64-redhat-linux-gnu/x3270/../../../x3270/xscreen.h:167: first defined here
/usr/bin/ld: keymap.o:/builddir/build/BUILD/suite3270-3.6/obj/x86_64-redhat-linux-gnu/x3270/../../../x3270/xscreen.h:166: multiple definition of `font_list'; about.o:/builddir/build/BUILD/suite3270-3.6/obj/x86_64-redhat-linux-gnu/x3270/../../../x3270/xscreen.h:166: first defined here
/usr/bin/ld: keypad.o:/builddir/build/BUILD/suite3270-3.6/obj/x86_64-redhat-linux-gnu/x3270/../../../x3270/xscreen.h:167: multiple definition of `font_count'; about.o:/builddir/build/BUILD/suite3270-3.6/obj/x86_64-redhat-linux-gnu/x3270/../../../x3270/xscreen.h:167: first defined here
/usr/bin/ld: keypad.o:/builddir/build/BUILD/suite3270-3.6/obj/x86_64-redhat-linux-gnu/x3270/../../../x3270/xscreen.h:166: multiple definition of `font_list'; about.o:/builddir/build/BUILD/suite3270-3.6/obj/x86_64-redhat-linux-gnu/x3270/../../../x3270/xscreen.h:166: first defined here
/usr/bin/ld: menubar.o:/builddir/build/BUILD/suite3270-3.6/obj/x86_64-redhat-linux-gnu/x3270/../../../x3270/xscreen.h:167: multiple definition of `font_count'; about.o:/builddir/build/BUILD/suite3270-3.6/obj/x86_64-redhat-linux-gnu/x3270/../../../x3270/xscreen.h:167: first defined here
/usr/bin/ld: menubar.o:/builddir/build/BUILD/suite3270-3.6/obj/x86_64-redhat-linux-gnu/x3270/../../../x3270/xscreen.h:166: multiple definition of `font_list'; about.o:/builddir/build/BUILD/suite3270-3.6/obj/x86_64-redhat-linux-gnu/x3270/../../../x3270/xscreen.h:166: first defined here
/usr/bin/ld: nvt_gui.o:/builddir/build/BUILD/suite3270-3.6/obj/x86_64-redhat-linux-gnu/x3270/../../../x3270/xscreen.h:167: multiple definition of `font_count'; about.o:/builddir/build/BUILD/suite3270-3.6/obj/x86_64-redhat-linux-gnu/x3270/../../../x3270/xscreen.h:167: first defined here
/usr/bin/ld: nvt_gui.o:/builddir/build/BUILD/suite3270-3.6/obj/x86_64-redhat-linux-gnu/x3270/../../../x3270/xscreen.h:166: multiple definition of `font_list'; about.o:/builddir/build/BUILD/suite3270-3.6/obj/x86_64-redhat-linux-gnu/x3270/../../../x3270/xscreen.h:166: first defined here
/usr/bin/ld: popups.o:/builddir/build/BUILD/suite3270-3.6/obj/x86_64-redhat-linux-gnu/x3270/../../../x3270/xscreen.h:167: multiple definition of `font_count'; about.o:/builddir/build/BUILD/suite3270-3.6/obj/x86_64-redhat-linux-gnu/x3270/../../../x3270/xscreen.h:167: first defined here
/usr/bin/ld: popups.o:/builddir/build/BUILD/suite3270-3.6/obj/x86_64-redhat-linux-gnu/x3270/../../../x3270/xscreen.h:166: multiple definition of `font_list'; about.o:/builddir/build/BUILD/suite3270-3.6/obj/x86_64-redhat-linux-gnu/x3270/../../../x3270/xscreen.h:166: first defined here
/usr/bin/ld: save.o:/builddir/build/BUILD/suite3270-3.6/obj/x86_64-redhat-linux-gnu/x3270/../../../x3270/xscreen.h:167: multiple definition of `font_count'; about.o:/builddir/build/BUILD/suite3270-3.6/obj/x86_64-redhat-linux-gnu/x3270/../../../x3270/xscreen.h:167: first defined here
/usr/bin/ld: save.o:/builddir/build/BUILD/suite3270-3.6/obj/x86_64-redhat-linux-gnu/x3270/../../../x3270/xscreen.h:166: multiple definition of `font_list'; about.o:/builddir/build/BUILD/suite3270-3.6/obj/x86_64-redhat-linux-gnu/x3270/../../../x3270/xscreen.h:166: first defined here
/usr/bin/ld: screen.o:/builddir/build/BUILD/suite3270-3.6/obj/x86_64-redhat-linux-gnu/x3270/../../../x3270/xscreen.h:166: multiple definition of `font_list'; about.o:/builddir/build/BUILD/suite3270-3.6/obj/x86_64-redhat-linux-gnu/x3270/../../../x3270/xscreen.h:166: first defined here
/usr/bin/ld: screen.o:/builddir/build/BUILD/suite3270-3.6/obj/x86_64-redhat-linux-gnu/x3270/../../../x3270/xscreen.h:167: multiple definition of `font_count'; about.o:/builddir/build/BUILD/suite3270-3.6/obj/x86_64-redhat-linux-gnu/x3270/../../../x3270/xscreen.h:167: first defined here
/usr/bin/ld: select.o:/builddir/build/BUILD/suite3270-3.6/obj/x86_64-redhat-linux-gnu/x3270/../../../x3270/xscreen.h:167: multiple definition of `font_count'; about.o:/builddir/build/BUILD/suite3270-3.6/obj/x86_64-redhat-linux-gnu/x3270/../../../x3270/xscreen.h:167: first defined here
/usr/bin/ld: select.o:/builddir/build/BUILD/suite3270-3.6/obj/x86_64-redhat-linux-gnu/x3270/../../../x3270/xscreen.h:166: multiple definition of `font_list'; about.o:/builddir/build/BUILD/suite3270-3.6/obj/x86_64-redhat-linux-gnu/x3270/../../../x3270/xscreen.h:166: first defined here
/usr/bin/ld: status.o:/builddir/build/BUILD/suite3270-3.6/obj/x86_64-redhat-linux-gnu/x3270/../../../x3270/xscreen.h:167: multiple definition of `font_count'; about.o:/builddir/build/BUILD/suite3270-3.6/obj/x86_64-redhat-linux-gnu/x3270/../../../x3270/xscreen.h:167: first defined here
/usr/bin/ld: status.o:/builddir/build/BUILD/suite3270-3.6/obj/x86_64-redhat-linux-gnu/x3270/../../../x3270/xscreen.h:166: multiple definition of `font_list'; about.o:/builddir/build/BUILD/suite3270-3.6/obj/x86_64-redhat-linux-gnu/x3270/../../../x3270/xscreen.h:166: first defined here
/usr/bin/ld: x3270.o:/builddir/build/BUILD/suite3270-3.6/obj/x86_64-redhat-linux-gnu/x3270/../../../x3270/xscreen.h:167: multiple definition of `font_count'; about.o:/builddir/build/BUILD/suite3270-3.6/obj/x86_64-redhat-linux-gnu/x3270/../../../x3270/xscreen.h:167: first defined here
/usr/bin/ld: x3270.o:/builddir/build/BUILD/suite3270-3.6/obj/x86_64-redhat-linux-gnu/x3270/../../../x3270/xscreen.h:166: multiple definition of `font_list'; about.o:/builddir/build/BUILD/suite3270-3.6/obj/x86_64-redhat-linux-gnu/x3270/../../../x3270/xscreen.h:166: first defined here
/usr/bin/ld: xactions.o:/builddir/build/BUILD/suite3270-3.6/obj/x86_64-redhat-linux-gnu/x3270/../../../x3270/xscreen.h:167: multiple definition of `font_count'; about.o:/builddir/build/BUILD/suite3270-3.6/obj/x86_64-redhat-linux-gnu/x3270/../../../x3270/xscreen.h:167: first defined here
/usr/bin/ld: xactions.o:/builddir/build/BUILD/suite3270-3.6/obj/x86_64-redhat-linux-gnu/x3270/../../../x3270/xscreen.h:166: multiple definition of `font_list'; about.o:/builddir/build/BUILD/suite3270-3.6/obj/x86_64-redhat-linux-gnu/x3270/../../../x3270/xscreen.h:166: first defined here
/usr/bin/ld: xkybd.o:/builddir/build/BUILD/suite3270-3.6/obj/x86_64-redhat-linux-gnu/x3270/../../../x3270/xscreen.h:167: multiple definition of `font_count'; about.o:/builddir/build/BUILD/suite3270-3.6/obj/x86_64-redhat-linux-gnu/x3270/../../../x3270/xscreen.h:167: first defined here
/usr/bin/ld: xkybd.o:/builddir/build/BUILD/suite3270-3.6/obj/x86_64-redhat-linux-gnu/x3270/../../../x3270/xscreen.h:166: multiple definition of `font_list'; about.o:/builddir/build/BUILD/suite3270-3.6/obj/x86_64-redhat-linux-gnu/x3270/../../../x3270/xscreen.h:166: first defined here
collect2: error: ld returned 1 exit status
make[2]: Leaving directory '/builddir/build/BUILD/suite3270-3.6/obj/x86_64-redhat-linux-gnu/x3270'
make[2]: *** [../../../x3270/Makefile.obj:82: x3270] Error 1
make[1]: *** [Makefile:39: all] Error 2

[Paul Mattes]

Thank you for the report.

I've fixed this and will push out 3.6 and 4.0 (master) changes shortly.

[Paul Mattes]

The fix has been released as 3.6ga9.