From: Pierre C. <chi...@cp...> - 2003-05-07 12:48:02
|
On Tue, May 06, 2003 at 05:26:13PM +0400, Roman Bogorodskiy wrote: > Hi! > > I'v made syslog support for wzdftpd but it is hm... not very stable. > It is needed to test it. I made changes on wzdftp-0.1.tar.gz (you send > me this via e-mail when finished FreeBSD support). I removed xferlog > logging function (it is not needed) and log_err. Trancleating wzd log > levels to syslog log levels you can see in wzd_log.c. Now wzdftp logs > all messages, despite on config setting, but it is simple to fix, I'll > fix this soon later. There is some more serios problem - I have > sometimes segfaults :( I don't know why yet. > > Waiting for your comments.. Hi Roman, I've integrated your patch, but after some modifications i'll explain: * I'd prefer to keep 2 different functions out_log and out_err, especially for debug * I have to keep the possibility to log directly to a file (and not to syslog), mainly because of the cygwin version (but the default is syslog now) The syslog part is now working ! I didn't get any segfault yet, but the bsd version seems to have a different behavior ... i'll work on it. > > PS Besides, I added long command line arguments, for example, `--help`. > For more datails - `wzdftpd --help` or `-h` I haven't found the file wzd_opts.h in the patch, so I couldn't integrate this part, although it seems very interesting. Can you send me this part again ? (I guess you missed the flag -N in your diff command). I'll merge it too, but it need some tricks in the configure.in (not all systems support getopt_long, the compilation will be conditionnal). Many thanks for your contributions ! Please send me you comments on the patch if I forgot something. /P -- Pierre CHIFFLIER "I code, therefore I am." |
From: Roman B. <bog...@in...> - 2003-05-08 12:34:12
|
Pierre wrote: > I've integrated your patch, but after some modifications i'll explain: > > * I'd prefer to keep 2 different functions out_log and out_err, > especially for debug > > * I have to keep the possibility to log directly to a file (and not to > syslog), mainly because of the cygwin version (but the default is > syslog now) Oh, I forgot about adout cygwin at all... > The syslog part is now working ! I didn't get any segfault yet, but > the bsd version seems to have a different behavior ... i'll work on > it. I'll test it ASAP. > I haven't found the file wzd_opts.h in the patch, so I couldn't > integrate this part, although it seems very interesting. Can you send > me this part again ? (I guess you missed the flag -N in your diff > command). I'll merge it too, but it need some tricks in the > configure.in (not all systems support getopt_long, the compilation > will be conditionnal). Now I'm applaying lastest patches apaired (wzdftpd/backends/plaintext, polux, wzdftpd/src, pollux) and then I'll try to realize longoptions support.... -Roman Bogorodskiy [Novel] |
From: Roman B. <bog...@in...> - 2003-05-09 17:44:43
|
Pierre wrote: > Many thanks for your contributions ! Please send me you comments on > the patch if I forgot something. I think it will be better to make only one log function (out_err for example), and in this function define log method (to file, to syslog, etc). IMHO, it'll make logging in wzdftpd more clear. -Roman Bogorodskiy [Novel] |
From: pollux <po...@wz...> - 2003-05-23 15:15:20
|
On Fri, May 09, 2003 at 09:44:38PM +0400, Roman Bogorodskiy wrote: > > I think it will be better to make only one log function (out_err for > example), and in this function define log method (to file, to syslog, > etc). IMHO, it'll make logging in wzdftpd more clear. > Hi, it sounds like a good idea to unify all the output methods. I'll begin to implement that just after the bugfixing period (until v0.1 is out), because I prefer not to change api when trying to fix bugs. A CVS branch would surely be adapted for that, but I'm not used to that (though I am not against). It is clear that this idea could be extended on all the code, trying to get a clean api. BTW, developper docs (generated by doxygen) should be available shortly, that would be of great help. /P -- po...@wz... |