From: Pierre C. <chi...@cp...> - 2003-05-07 12:48:02
|
On Tue, May 06, 2003 at 05:26:13PM +0400, Roman Bogorodskiy wrote: > Hi! > > I'v made syslog support for wzdftpd but it is hm... not very stable. > It is needed to test it. I made changes on wzdftp-0.1.tar.gz (you send > me this via e-mail when finished FreeBSD support). I removed xferlog > logging function (it is not needed) and log_err. Trancleating wzd log > levels to syslog log levels you can see in wzd_log.c. Now wzdftp logs > all messages, despite on config setting, but it is simple to fix, I'll > fix this soon later. There is some more serios problem - I have > sometimes segfaults :( I don't know why yet. > > Waiting for your comments.. Hi Roman, I've integrated your patch, but after some modifications i'll explain: * I'd prefer to keep 2 different functions out_log and out_err, especially for debug * I have to keep the possibility to log directly to a file (and not to syslog), mainly because of the cygwin version (but the default is syslog now) The syslog part is now working ! I didn't get any segfault yet, but the bsd version seems to have a different behavior ... i'll work on it. > > PS Besides, I added long command line arguments, for example, `--help`. > For more datails - `wzdftpd --help` or `-h` I haven't found the file wzd_opts.h in the patch, so I couldn't integrate this part, although it seems very interesting. Can you send me this part again ? (I guess you missed the flag -N in your diff command). I'll merge it too, but it need some tricks in the configure.in (not all systems support getopt_long, the compilation will be conditionnal). Many thanks for your contributions ! Please send me you comments on the patch if I forgot something. /P -- Pierre CHIFFLIER "I code, therefore I am." |