Re: [wxVTK] 1.4 please!
Brought to you by:
malat
|
From: Andrew T. <an...@tr...> - 2011-12-06 22:25:54
|
Sander Niemeijer wrote: > I am a bit concerned about this patch. > It removes elements that could cause problems with wxWidgets 2.8 > (even if it is just the cocoa backend of wxWidgets 2.8). My changes shouldn't affect people using Carbon builds of wx 2.8.x. As I indicated in my previous message, I doubt there is anybody using Cocoa builds of wx 2.8.x, and their apps wouldn't have worked properly anyway. > And I am also not in favor of commenting out code the way the patch does. If code is no longer applicable please remove the whole section. Don't leave it there in between '/*' '*/'. All those changes were just a quick hack to get things working. I wanted to leave in the old code in case I needed to go back. Someone else (you or Mathieu) needs to remove my "AKT" comments and do any other tidying up. Andrew |