Re: [wxVTK] 1.4 please!

SourceForge Headquarters 225 Broadway Suite 1600 San Diego, CA 92101 +1 (858) 422-6466

For our project we are still relying on wxWidgets 2.8 with Carbon for  
MacOSX. It is on my TODO list to have a look at Cocoa and wxWidgets  
2.9, but this may be a while. So currently I am not in the position to  
test your commits yet (although I will definitely have a go at it in  
the future).

I also don't know if anyone is actually using wxVTK together with  
wxWidgets 2.8 and the Cocoa backend. But just in case, it may be a  
good approach to include your changes using a wxCHECK_VERSION(2, 9, 0)  
just to keep the old 2.8 behaviour as-is.

And note that you can use (e.g. line 412 in your patch):

#if !defined(__WXCOCOA__)
....
#endif

instead of:

#if __WXCOCOA__
#else
....
#endif

Best regards,
Sander

On 5 dec 2011, at 17:28, Tim Hutton wrote:

> Yes, sorry, this diff is from our project, I wasn't proposing to apply
> the same diff to wxVTK. Ideally we would understand the underlying
> problem that Andrew managed to fix and apply a solution to wxVTK.
>
> I'm happy to commit some code that looks sensible along these lines
> but it's slightly risky because I'm not on MacOS. Are you on
> MacOS+Cocoa, Sander? We could give Andrew commit rights, if he has the
> time to spend on this.
>
> On 5 December 2011 15:45, Sander Niemeijer <nie...@st...>  
> wrote:
>> I am a bit concerned about this patch.
>> It removes elements that could cause problems with wxWidgets 2.8  
>> (even if it
>> is just the cocoa backend of wxWidgets 2.8). Try to use  
>> wxCHECK_VERSION
>> where this is needed.
>>
>> And I am also not in favor of commenting out code the way the patch  
>> does. If
>> code is no longer applicable please remove the whole section. Don't  
>> leave it
>> there in between '/*' '*/'.
>>
>> Best regards,
>> Sander
>>
>>
>> On 5 dec 2011, at 15:31, Tim Hutton wrote:
>>
>>> Hi Mathieu,
>>>
>>> Yes, no problem. Andrew, do you think there would be a negative  
>>> impact
>>> on users of different vtk versions, or non-Cocoa users, or others?
>>>
>>> On 5 December 2011 14:19, Mathieu Malaterre <mat...@gm... 
>>> >
>>> wrote:
>>>>
>>>> Hi Tim,
>>>>
>>>>  Thanks for the quick feedback. I just gave you write access to  
>>>> wxVTK
>>>> CVS. Would it be possible for you to directly incorported the  
>>>> needed
>>>> changes ?
>>>>
>>>> Thanks very much !
>>>>
>>>> On Mon, Dec 5, 2011 at 3:08 PM, Tim Hutton <tim...@gm...>  
>>>> wrote:
>>>>>
>>>>> After further investigations it looks like we needed another  
>>>>> change,
>>>>> to bring wxVTK into sync with vtk 5.8 on Cocoa:
>>>>>
>>>>> https://code.google.com/p/reaction-diffusion/source/diff?spec=svn200&r=200&format=side&path=/trunk/ReaDy_gui/wxVTKRenderWindowInteractor.cxx
>>>>>
>>>>> With these changes the wxVTK samples are now reported to be  
>>>>> working
>>>>> fully on Cocoa with wxOSX 2.9.x.
>>>>>
>>>>> CC'ing Andrew in case there are any questions.
>>>>>
>>>>> On 3 December 2011 17:34, Mathieu Malaterre
>>>>> <mat...@gm...> wrote:
>>>>>>
>>>>>> Thanks everyone ! Very much appreciated for the quick feedback.
>>>>>>
>>>>>> On Thu, Dec 1, 2011 at 10:58 AM, Tim Hutton  
>>>>>> <tim...@gm...>
>>>>>> wrote:
>>>>>>>
>>>>>>> Andrew Trevorrow has committed this fix to our version, to get  
>>>>>>> it
>>>>>>> working on Cocoa in wxOSX 2.9.x.
>>>>>>>
>>>>>>> https://code.google.com/p/reaction-diffusion/source/diff?spec=svn199&r=199&format=side&path=/trunk/ReaDy_gui/wxVTKRenderWindowInteractor.cxx
>>>>>>>
>>>>>>> I'm not on MacOS myself but he says it is needed.
>>>>>>>
>>>>>>> On 30 November 2011 14:47, Sander Niemeijer  
>>>>>>> <nie...@st...>
>>>>>>> wrote:
>>>>>>>>
>>>>>>>> Hi Mathieu,
>>>>>>>>
>>>>>>>> I did a quick compare of the current wxVTK CVS with what we  
>>>>>>>> are using
>>>>>>>> internally. There is currently one difference:
>>>>>>>> The patch below is to fix a redrawing issue we encountered on  
>>>>>>>> Windows
>>>>>>>> when windows got resized. It was something we fixed in  
>>>>>>>> September
>>>>>>>> 2009,
>>>>>>>> so I don't know the precise details anymore.
>>>>>>>>
>>>>>>>> I would appreciate it if you could include this patch for v1.4.
>>>>>>>>
>>>>>>>> Best regards,
>>>>>>>> Sander Niemeijer
>>>>>>>>
>>>>>>>> --- cvs/wxVTKRenderWindowInteractor.cxx 2009-03-05  
>>>>>>>> 17:00:43.000000000
>>>>>>>> +0100
>>>>>>>> +++ new/wxVTKRenderWindowInteractor.cxx 2009-09-04  
>>>>>>>> 11:50:25.000000000
>>>>>>>> +0200
>>>>>>>> @@ -281,6 +281,9 @@
>>>>>>>>       Size[1] = y;
>>>>>>>>       // and our RenderWindow's size
>>>>>>>>       RenderWindow->SetSize(x, y);
>>>>>>>> +#if defined(__WXMSW__)
>>>>>>>> +      this->Refresh();
>>>>>>>> +#endif //__WXMSW__
>>>>>>>>     }
>>>>>>>>   }
>>>>>>>>  }
>>>>>>>>
>>>>>>>>
>>>>>>>> On 30 nov 2011, at 15:10, Mathieu Malaterre wrote:
>>>>>>>>
>>>>>>>>> Hi Tim,
>>>>>>>>>
>>>>>>>>>  Ok will do. I'll do that on Friday.
>>>>>>>>>
>>>>>>>>> Everyone,
>>>>>>>>>
>>>>>>>>>  Last call for integrating your patch in 1.4 release. You'll  
>>>>>>>>> have to
>>>>>>>>> wait another ~3yrs or so otherwise ;)
>>>>>>>>>
>>>>>>>>> Thanks !
>>>>>>>>>
>>>>>>>>> On Wed, Nov 30, 2011 at 1:03 PM, Tim Hutton <tim...@gm... 
>>>>>>>>> >
>>>>>>>>> wrote:
>>>>>>>>>>
>>>>>>>>>> Hello,
>>>>>>>>>>
>>>>>>>>>> I've just been bitten by the fact that the 1.3 download  
>>>>>>>>>> (from 2008)
>>>>>>>>>> is
>>>>>>>>>> older than some of the fixes in the CVS head. Specifically:  
>>>>>>>>>> the
>>>>>>>>>> Timer
>>>>>>>>>> error has gone, and the Cocoa build wasn't working. I see  
>>>>>>>>>> there are
>>>>>>>>>> around 8 downloads a week so presumably all of these people  
>>>>>>>>>> are
>>>>>>>>>> being
>>>>>>>>>> hit by these issues too! So please make a new download.
>>>>>>>>>>
>>>>>>>>>> And thankyou thankyou thankyou for maintaining wxVTK. I've  
>>>>>>>>>> been
>>>>>>>>>> using
>>>>>>>>>> it continuously for several years now.
>>>>>>>>>>
>>>>>>>>>> --
>>>>>>>>>> Tim Hutton - http://www.sq3.org.uk -
>>>>>>>>>> http://profiles.google.com/tim.hutton/
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>> ------------------------------------------------------------------------------
>>>>>>>>>> All the data continuously generated in your IT infrastructure
>>>>>>>>>> contains a definitive record of customers, application  
>>>>>>>>>> performance,
>>>>>>>>>> security threats, fraudulent activity, and more. Splunk  
>>>>>>>>>> takes this
>>>>>>>>>> data and makes sense of it. IT sense. And common sense.
>>>>>>>>>> http://p.sf.net/sfu/splunk-novd2d
>>>>>>>>>> _______________________________________________
>>>>>>>>>> Wxvtk-users mailing list
>>>>>>>>>> Wxv...@li...
>>>>>>>>>> https://lists.sourceforge.net/lists/listinfo/wxvtk-users
>>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>> --
>>>>>>>>> Mathieu
>>>>>>>>>
>>>>>>>>>
>>>>>>>>> ------------------------------------------------------------------------------
>>>>>>>>> All the data continuously generated in your IT infrastructure
>>>>>>>>> contains a definitive record of customers, application  
>>>>>>>>> performance,
>>>>>>>>> security threats, fraudulent activity, and more. Splunk  
>>>>>>>>> takes this
>>>>>>>>> data and makes sense of it. IT sense. And common sense.
>>>>>>>>> http://p.sf.net/sfu/splunk-novd2d
>>>>>>>>> _______________________________________________
>>>>>>>>> Wxvtk-users mailing list
>>>>>>>>> Wxv...@li...
>>>>>>>>> https://lists.sourceforge.net/lists/listinfo/wxvtk-users
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>> ------------------------------------------------------------------------------
>>>>>>>> All the data continuously generated in your IT infrastructure
>>>>>>>> contains a definitive record of customers, application  
>>>>>>>> performance,
>>>>>>>> security threats, fraudulent activity, and more. Splunk takes  
>>>>>>>> this
>>>>>>>> data and makes sense of it. IT sense. And common sense.
>>>>>>>> http://p.sf.net/sfu/splunk-novd2d
>>>>>>>> _______________________________________________
>>>>>>>> Wxvtk-users mailing list
>>>>>>>> Wxv...@li...
>>>>>>>> https://lists.sourceforge.net/lists/listinfo/wxvtk-users
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>> --
>>>>>>> Tim Hutton - http://www.sq3.org.uk -
>>>>>>> http://profiles.google.com/tim.hutton/
>>>>>>
>>>>>>
>>>>>>
>>>>>>
>>>>>> --
>>>>>> Mathieu
>>>>>
>>>>>
>>>>>
>>>>>
>>>>> --
>>>>> Tim Hutton - http://www.sq3.org.uk -
>>>>> http://profiles.google.com/tim.hutton/
>>>>>
>>>>>
>>>>> ------------------------------------------------------------------------------
>>>>> All the data continuously generated in your IT infrastructure
>>>>> contains a definitive record of customers, application  
>>>>> performance,
>>>>> security threats, fraudulent activity, and more. Splunk takes this
>>>>> data and makes sense of it. IT sense. And common sense.
>>>>> http://p.sf.net/sfu/splunk-novd2d
>>>>> _______________________________________________
>>>>> Wxvtk-users mailing list
>>>>> Wxv...@li...
>>>>> https://lists.sourceforge.net/lists/listinfo/wxvtk-users
>>>>
>>>>
>>>>
>>>>
>>>> --
>>>> Mathieu
>>>
>>>
>>>
>>>
>>> --
>>> Tim Hutton - http://www.sq3.org.uk -
>>> http://profiles.google.com/tim.hutton/
>>>
>>>
>>> ------------------------------------------------------------------------------
>>> All the data continuously generated in your IT infrastructure
>>> contains a definitive record of customers, application performance,
>>> security threats, fraudulent activity, and more. Splunk takes this
>>> data and makes sense of it. IT sense. And common sense.
>>> http://p.sf.net/sfu/splunk-novd2d
>>> _______________________________________________
>>> Wxvtk-users mailing list
>>> Wxv...@li...
>>> https://lists.sourceforge.net/lists/listinfo/wxvtk-users
>>
>>
>
>
>
> -- 
> Tim Hutton - http://www.sq3.org.uk - http://profiles.google.com/tim.hutton/
>
> ------------------------------------------------------------------------------
> All the data continuously generated in your IT infrastructure
> contains a definitive record of customers, application performance,
> security threats, fraudulent activity, and more. Splunk takes this
> data and makes sense of it. IT sense. And common sense.
> http://p.sf.net/sfu/splunk-novd2d
> _______________________________________________
> Wxvtk-users mailing list
> Wxv...@li...
> https://lists.sourceforge.net/lists/listinfo/wxvtk-users