Re: [wxVTK] wxVTKRenderWindowInteractor.cxx, 1.47, 1.48

[Mathieu M. <mat...@gm...>]

On Thu, Mar 5, 2009 at 4:59 PM, Sander Niemeijer <nie...@st...> wrote:
>
> On 5 mrt 2009, at 16:35, Pierre Fillard wrote:
>
>>> I would suggest making the definition of wxvtk_attributes static.
>>> This will prevent the symbol becoming exported.
>>
>> Sure. I'll change it to static.
>
> Thanks.
>
>>> Also, you have removed the wxCHECK_VERSION(2, 8, 0). Are you sure
>>> that your invocation of the wxGLCanvas constructor will also work
>>> with versions of wxWidgets before 2.8?
>>
>> I guess so. Previous versions of wx allowed to call the wxGLCanvas
>> constructor with zero argument (all were defaulted to some values in
>> the header) which was changed in recent versions. The current
>> constructor seems to be "backward compatible", but I may be wrong.
>> Problem is that I have to call the constructor with all its
>> arguments to pass it the openGL attribute list, which is the only
>> possibility to pass it. Otherwise I can do my openGL trick only for
>> wx>2.8 and leave constructor unchanged for older versions (but the
>> flickering problem may persist).
>
> I just checked with the wxWidgets docs and it seems that the
> constructor invocation should indeed be compatible back to at least 2.4.

I think I was the one adding it because at some point backward
compatibility was broken:

http://groups.google.com/group/comp.soft-sys.wxwindows/browse_thread/thread/dfc1b064ac30f4f5

I guess this has been fixed since.

Thanks guys !
-- 
Mathieu