Re: [wxperl-users] Wx::Font patch

[Mattia B. <mat...@li...>]

On Thu, 03 May 2007 00:20:43 +0100
Mark Dootson <mar...@zn...> wrote:

  Hi,

> Attached patch adds some missing methods and constants to Wx::Font plus one missing method to Wx::ScrolledWindow.
> 
> Tested on VC6/wxMSW & gcc/wxGTK
> 
> It is a straightforward wrap of the methods / constants.
> 
> One thing is that wxFont has an overloaded static method - 'New'. I need this because I want to create fonts via pixel sizes in wxMSW, and have the same method at least run on wxGTK.
> 
> I have left the method as Wx::Font->New, because that agrees with the docs. However, I'm not sure if that will
> confuse too much against Wx::Font->new. I thought, on balance, it is best if the interface is as close to the docs as possible.

  Having it as a Perl static method is inconsistent with all other C++
static methods which are callable as Wx::Class::DoFoo, not
Wx::Class->DoFoo; I have committed your patch as-is, but I will change
->New to ::New in the next commit.

Best regards
Mattia