Hello,
First, thanks for this nice work, it is very usefull for my software.
I compiled wxmathplot in release Mode(gcc 4.3.2_2 under win32), all warnings activated, I have some questions:
Line 654 in mathplot.cpp: (warning is : statement has no effect)
if (m_drawOutsideMargins) X_BORDER_SEPARATION;
should it be?:
if (m_drawOutsideMargins) orgy = X_BORDER_SEPARATION;
line 858: (startPx is unused ) potential bug here? wxCoord startPx = m_drawOutsideMargins ? 0 : w.GetMarginLeft();
a lot of unused events:
like in:
void mpWindow::OnLockAspect(wxCommandEvent &event) { LockAspect( !m_lockaspect ); }
so I hadded a (void) to tell the compiler to ignore it:
void mpWindow::OnLockAspect(wxCommandEvent &event) { (void)event; LockAspect( !m_lockaspect ); }
Sorry, I didn't commit these, since I don't want to break stuffs...But I can send the file mathplot.cpp if you want.
Thanks again !
Etienne
Log in to post a comment.
Hello,
First, thanks for this nice work, it is very usefull for my software.
I compiled wxmathplot in release Mode(gcc 4.3.2_2 under win32), all warnings activated, I have some questions:
Line 654 in mathplot.cpp: (warning is : statement has no effect)
if (m_drawOutsideMargins)
X_BORDER_SEPARATION;
should it be?:
if (m_drawOutsideMargins)
orgy = X_BORDER_SEPARATION;
line 858: (startPx is unused ) potential bug here?
wxCoord startPx = m_drawOutsideMargins ? 0 : w.GetMarginLeft();
a lot of unused events:
like in:
void mpWindow::OnLockAspect(wxCommandEvent &event)
{
LockAspect( !m_lockaspect );
}
so I hadded a (void) to tell the compiler to ignore it:
void mpWindow::OnLockAspect(wxCommandEvent &event)
{
(void)event;
LockAspect( !m_lockaspect );
}
Sorry, I didn't commit these, since I don't want to break stuffs...But I can send the file mathplot.cpp if you want.
Thanks again !
Etienne