From: Fernando B. <gre...@gm...> - 2009-09-04 14:01:53
|
Hi all, I'm working in my first project with wxHaskell. My project includes an editor, so I wanted to add find&replace functionality to it but then I stepped into what I think is a little bug. I think you'll see the problem clearly with an example (and it will be easier for me than explaining it in english :P): Let's say you've got the following code > *s* <- *findReplaceDataCreateDefault* > *findReplaceDataSetFindString* *s* "find" > *findReplaceDataSetReplaceString* *s* "replace" > *r* <- *findReplaceDataGetReplaceString* *s* > You expect that, when executed, the value of r will be "replace", but it's not. It's "find" instead. Googleing a bit, I've found that this is a known bug in wxEiffel: http://www.mombu.com/programming/eiffel/t-problems-getting-a-wx-find-replace-data-1408529.html Then, I've checked the source code for wxHaskell ( http://darcs.haskell.org/wxhaskell/wxc/src/eljfindrepldlg.cpp) and found this: EWXWEXPORT(wxString*,*wxFindReplaceData_GetReplaceString*)(void* _obj) > { > wxString *result = new wxString(); > *result = ((wxFindReplaceData*)_obj)->*GetFindString*(); > return result; > } > I think that explains it. Then I decided to write this mail to let you know about it, so maybe it can be fixed in the next wxHaskell release :) Cheers!! Joan Crawford<http://www.brainyquote.com/quotes/authors/j/joan_crawford.html> - "I, Joan Crawford, I believe in the dollar. Everything I earn, I spend." |
From: Eric Y. K. <eri...@gm...> - 2009-09-05 09:12:39
|
On Fri, Sep 04, 2009 at 10:32:04 -0300, Fernando Benavides wrote: > Googleing a bit, I've found that this is a known bug in wxEiffel: > http://www.mombu.com/programming/eiffel/t-problems-getting-a-wx-find-replace-data-1408529.html > Then, I've checked the source code for wxHaskell ( > http://darcs.haskell.org/wxhaskell/wxc/src/eljfindrepldlg.cpp) and found > this: Thanks for this! Is http://code.haskell.org/wxhaskell/wxc/src/eljfindrepldlg.cpp also wrong? The repo has been moved to code.haskell.org. This sort of thing makes me wish for wxC unification. -- Eric Kow <http://www.nltg.brighton.ac.uk/home/Eric.Kow> PGP Key ID: 08AC04F9 |
From: Fernando B. <gre...@gm...> - 2009-09-05 15:17:09
|
Hi Eric That file has the bug too, indeed Pablo Picasso<http://www.brainyquote.com/quotes/authors/p/pablo_picasso.html> - "Computers are useless. They can only give you answers." On Sat, Sep 5, 2009 at 6:12 AM, Eric Y. Kow <eri...@gm...> wrote: > On Fri, Sep 04, 2009 at 10:32:04 -0300, Fernando Benavides wrote: > > Googleing a bit, I've found that this is a known bug in wxEiffel: > > > http://www.mombu.com/programming/eiffel/t-problems-getting-a-wx-find-replace-data-1408529.html > > Then, I've checked the source code for wxHaskell ( > > http://darcs.haskell.org/wxhaskell/wxc/src/eljfindrepldlg.cpp) and found > > this: > > Thanks for this! > > Is http://code.haskell.org/wxhaskell/wxc/src/eljfindrepldlg.cpp > also wrong? > > The repo has been moved to code.haskell.org. This sort of thing makes > me wish for wxC unification. > > -- > Eric Kow <http://www.nltg.brighton.ac.uk/home/Eric.Kow> > PGP Key ID: 08AC04F9 > |
From: Eric Y. K. <eri...@gm...> - 2009-09-30 20:14:31
|
Hi Fernando, On Sat, Sep 05, 2009 at 12:17:01 -0300, Fernando Benavides wrote: > That file has the bug too, indeed Very sorry for my late response, but would you consider sending a patch? I seem to remember you managed to fix this by looking into the wxEiffel version of wxc darcs get http://code.haskell.org/wxhaskell darcs record darcs send Thanks! -- Eric Kow <http://www.nltg.brighton.ac.uk/home/Eric.Kow> PGP Key ID: 08AC04F9 |
From: shelarcy <she...@gm...> - 2009-10-01 03:49:27
|
Pushed. Thanks, On Thu, 01 Oct 2009 11:05:54 +0900, shelarcy <she...@gm...> wrote: > On Thu, 01 Oct 2009 06:01:36 +0900, Eric Y. Kow <eri...@gm...> wrote: >> On Wed, Sep 30, 2009 at 17:59:00 -0300, Fernando Benavides wrote: >>> I'm attaching the patch because (after just 5'' trying - I'm in my workplace >>> now :P) I couldn't get darcs send to work. >> >> Thanks for being a good sport about this! Could somebody on the >> wxHaskell Team take a look at Fernando's patch? > > I think this is a reasonable change. So, I'll push his patch after > trying to build wxHaskell with it. -- shelarcy <shelarcy hotmail.co.jp> http://page.freett.com/shelarcy/ |
From: Fernando B. <gre...@gm...> - 2010-01-22 15:36:10
|
Hi, me again... I'm using the current darcs version of wxhaskell (darcs get --partial --set-scripts-executable http://code.haskell.org/wxhaskell/) and seems like this patch is not applied and the code in eljfindrepldlg.cpp is wrong again. Can someone check it out, please? Thanks. Marie von Ebner-Eschenbach<http://www.brainyquote.com/quotes/authors/m/marie_von_ebnereschenbac.html> - "Even a stopped clock is right twice a day." 2009/10/1 shelarcy <she...@gm...> > Pushed. Thanks, > > > On Thu, 01 Oct 2009 11:05:54 +0900, shelarcy <she...@gm...> wrote: > >> On Thu, 01 Oct 2009 06:01:36 +0900, Eric Y. Kow <eri...@gm...> >> wrote: >> >>> On Wed, Sep 30, 2009 at 17:59:00 -0300, Fernando Benavides wrote: >>> >>>> I'm attaching the patch because (after just 5'' trying - I'm in my >>>> workplace >>>> now :P) I couldn't get darcs send to work. >>>> >>> >>> Thanks for being a good sport about this! Could somebody on the >>> wxHaskell Team take a look at Fernando's patch? >>> >> >> I think this is a reasonable change. So, I'll push his patch after >> trying to build wxHaskell with it. >> > > -- > shelarcy <shelarcy hotmail.co.jp> > http://page.freett.com/shelarcy/ > |