wxhaskell-devel

[wxhaskell-devel] Modified example ImageViewer.hs

[D.V. <dav...@gm...>]

Bonjour List,

A few weeks ago I needed help to find out how to scale an image.
Once I managed to make it work, I was suggested to modify the example
to show how it can be done.

So here's a quickly modified ImageViewer.hs. It's not a big change !

I'd like someone to review the changes before I send a patch, please.

Thanks,

David.

Re: [wxhaskell-devel] Modified example ImageViewer.hs

[Eric Y. K. <eri...@gm...>]

On Fri, Sep 16, 2011 at 22:52:51 +0200, D.V. wrote:
> So here's a quickly modified ImageViewer.hs. It's not a big change !
> 
> I'd like someone to review the changes before I send a patch, please.

Didn't look too carefully, but seems to make sense.

Sounds like it'd be a good way to help for folks who are just starting
to contribute to wxHaskell (and thanks btw, from a grateful
wxhaskell-user)

I'd split the cleanup patches (like adding a type signature to existing
stuff) from the new feature patches, but you can send them all in one
bundle

-- 
Eric Kow <http://erickow.com>

Re: [wxhaskell-devel] Modified example ImageViewer.hs

[David V. <dav...@gm...>]

2011/9/21 Eric Y. Kow <eri...@gm...>:

> I'd split the cleanup patches (like adding a type signature to existing
> stuff) from the new feature patches, but you can send them all in one
> bundle

Ok so this is where I don't know how to do it.

When I modified Imageviewer.hs, I recorded separately the cleanup and
new feature patches using darcs, but :
When trying to build a version of wxwidgets so I can maybe help
contribute, I deleted my wxhaskell directory (doh) to get a fresh
version... Losing my modifications and the history.

I can get ImageViewer.hs back since I sent it to the list, but I lost
the history.

Let's say I take the time to learn how to re-record it cleanly, what
do I do next ?

David.

Re: [wxhaskell-devel] Modified example ImageViewer.hs

[Eric K. <eri...@gm...>]

On Wed, Sep 21, 2011 at 20:20:27 +0200, David Virebayre wrote:
> 2011/9/21 Eric Y. Kow <eri...@gm...>:
> 
> > I'd split the cleanup patches (like adding a type signature to existing
> > stuff) from the new feature patches, but you can send them all in one
> > bundle
> 
> Ok so this is where I don't know how to do it.

> Let's say I take the time to learn how to re-record it cleanly, what
> do I do next ?

Are you talking about sending the patches?

You want to use the darcs send command.

- You need a working sendmail command. 
- You use it like you would use darcs push.
- You can send patches to any darcs repository URL or filepath

Try in order:

- darcs help send
- the manual
- http://wiki.darcs.net/Using/Send for some practical supplementary tips

Let me know if you need any specific help

-- 
Eric Kow <http://erickow.com>