Re: [wxhaskell-devel] wxWidgets 2.8.7 support

[shelarcy <she...@gm...>]

Hi Jeremy,

On Thu, 10 Apr 2008 23:12:50 +0900, Jeremy O'Donoghue <je...@o-...> wrote:
> Attached is a (zipped) preliminary set of patches for wxWidgets 2.8.7
> support. Some notes to help.
>
> - wxWidgets 2.8.7 was compiled from source using Visual Studio 2008

I tested your patch on PowerPC Mac OS X. And I found below part causes
compile error.

> [Preliminary wxWidgets 2.8.7 support
> jer...@gm...**20080410112559] {
> (snip)
> hunk ./wxc/src/eljvalidator.cpp 136
> (snip)
> +#ifdef wxUSE_UNICODE
> +      items_copy[i] = _wcsdup(items.Item(i).GetData());
> +#else
> +      items_copy[i] = strdup(items.Item(i).GetData());
> +#endif

_wcsdup is Visual Studio (2005 or higher)'s specific function. And wxchar
has portable wxStrdup function. So, I think we should use wxStrdup function
instead.

> - Compiled on top of both 0.10.3 rc1 (tagged) and the released version
> (head). Tested
>   against most of the samples/wx directory using rc1 (Windows only).

I checked those are also working on PowerPC Mac OS X platform. Some sample
cause problem. But anyway we have working code now.

That is sounds great!

> The general approach I've taken, as agreed with Eric when I discussed
> this patch, is to shoot for wxcore API which is as close as possible to
> wxWidgets 2.8. This breaks source compatibility in places, but has some
> advantages:

I don't check that yet. I'll check that this and/or next week.


Best Regards,

-- 
shelarcy <shelarcy    hotmail.co.jp>
http://page.freett.com/shelarcy/