Re: [wxhaskell-devel] darcs patch: Require --enable-unicode in wxWidgets. (and 1 more)

[Jeremy O'D. <je...@o-...>]

On Thu, 20 Mar 2008 17:50:06 +0900, "shelarcy" <she...@gm...>
said:
> Hi Eric,
> 
> On Thu, 20 Mar 2008 08:28:11 +0900, Eric Kow <eri...@gm...> wrote:
> > [Require --enable-unicode in wxWidgets.
> > Eric Kow <eri...@gm...>**20080318084054] hunk ./configure 759
> >  # wxWidgets
> >  #--------------------------------------------------------------------
> >  =
> >
> > +# confirm that we have unicode enabled
> > +`$wxconfig --unicode=3Dyes`
> > +if test "$?" =3D 0; then
> > +  echo " wxWidgets Unicode support found"
> > +else
> > +  echo ""
> > +  echo " I can't find the Unicode version of wxWidgets!"
> > +  echo ""
> > +  echo " Did you configure configure wxWidgets with --enable-unicode?"
> > +  echo " If you have more than one copy, are you passing in the right"
> > +  echo " version via --wx-config?"
> > +  exit 1
> > +fi
> 
> This cause the problem to use Visual Studio on Windows platform.
> If we build wxWidgets (wxMSW) by Visual Studio, there is no wxconfig
> command.
> And Windows binary's wxc dll links wxWidgets library statically. So,
> almost
> Windows users don't meet unicode problem.
> 

The suggested patch is OK as a temporary solution, but it certainly is
possible to build wxWidgets without Unicode on Windows, so it could
break in some cases.

It's true that there is no wx-config for Windows, but I think the right
approach will probably be to detect what is actually available on a
Windows host - much as wxconfig allows on Unix hosts.

It's not too hard as you can generally determine what is available given
the DLLs available and their names (e.g. wxmsw26ud.dll would represent a
Unicode debug build). 

We can certainly hold off on this for now. Given that Windows (since at
least Windows 98 if not earlier) has been primarily Unicode based

Regards
Jeremy