Re: [wxhaskell-devel] darcs patch: Bump to 0.10.3. (and 14 more)

[shelarcy <she...@gm...>]

Hi Eric,

On Wed, 05 Mar 2008 23:22:48 +0900, Eric Kow <eri...@gm...> wrote:
> More stuff related to a 0.10.3 release candidate.  Basically fixes to 'make
> bindist' on my end, and some documentation.  Now we need people to make
> packages for their platforms, test them out, etc.

It seems that your patch break bindist.

> [Fix dep: wx-bindist requires wx
> Eric Kow <eri...@gm...>**20080305112324] hunk ./makefile 698
>  	@$(call cp-srcdist, $^)
>  =
>
>  # bindist
> -wx-bindist: =
>
> +wx-bindist: wx
>  	@$(call cp-bindist,$(WX-OUTDIR),$(BINDIST-LIBDIR),$(WX-BINS))
>  ifdef ENABLE-PROF
>  	@$(call cp-bindist,$(WX-OUTDIR),$(BINDIST-LIBDIR),$(WX-PROF-BINS))

bindist includes wxcore-bindist and wx-bindist.
And "make wx" removes wxcore file.

ifdef ENABLE-PROF
wx: wx-main-only wx-prof
else
wx: wx-main-only
endif

wx-main-only: wxcore-clean wx-main

So, now "make bindist" removes wxcore file before generating bindist.
It is unexpected behaviour.


And I know one more problem on Windows.

> [Update hdocbases to work with haddock2 and ghc 6.8.2
> Eric Kow <eri...@gm...>**20080305134826
>  I'm not sure which, but this makes it compile on my end.
> ] {
>
> (snip)
>
>  # Find .haddock files
>  if test "$hdocfound" =3D "yes"; then
> hunk ./configure 683
>        6.0* | 6.1* | 6.2* | 6.3* | 6.4* | 6.5* | 6.6*)
>  	docroot=3D"$ghcroot/doc/html/libraries";;
>        6.*) =
>
> -	docroot=3D"$ghcroot/doc/libraries";;
> +	docroot=3D"$ghcroot/share/doc/ghc/libraries";;
>        *)
>  	docroot=3D"$ghcroot/doc/libraries";;
>      esac

$docroot isn't in share directory on Windows platform.
How about change following in this part?

         if test "$cygpathfound"; then
	  docroot="$ghcroot/doc/libraries"
         else
	  docroot="$ghcroot/share/doc/ghc/libraries"
         fi
         ;;


-- 
shelarcy <shelarcy    hotmail.co.jp>
http://page.freett.com/shelarcy/