From: Francesco M. <f18...@ya...> - 2005-07-13 21:14:23
|
Hi, >>do you mean that we should add the sf user name in the mails sent ? >>When you submit a component you must be registered as mantainer and thus >>you must have submitted a SF user name which is already in the DB... > > I guess it's ok, in order to update the CVS access of a component we > need the SF user name. I guess we can look it up in the wxcode > maintainer's database (I forgot about this). I mentioned this since > when I searched for "Jorgen Bodde" at SF (for people) it actually > doesn't come up with him. :/ On a chance I tried "jorgb" and verified > his SF user name. Maybe this was a fluke, but to avoid this and also > to avoid problems with users with common names I thought it might make > sense to just put their SF name with the component in the component > database since they have to log in with it anyway. there would be a problem putting SF user names in the "components" table which has to do with database normalization: we would put redundant info in component entries since a mantainer can be associated to more components. So, that would really be a bad choice; it would also need a lot of work on the current PHP site code... :-( Also, it would not give any advantage.. see below >>If you mean that it's missing from the mails sent, I agree and I'll >>modify the script ASAP > > > I'm not sure what you mean about this, the mails sent from people can > be from any address, how will you look up their SF user name? Anyway, > if it makes sense, it sounds good to me. :) Ooops; sorry; I did not mean that; I meant that in the mails generated by dumppendingcomp.sh script, have in their body all the infos about the component which has been submitted but do not contain *any* info about the mantainer who submitted that component (the Author name can be different from the actual mantainer...) so I'm going to add such info in the mails generated by the script. So, when we receive the notification, we can read the mantainer's sf username directly in the mail... ;-) Francesco |