[wxCode-users] [ wxcode-Patches-2861075 ] DatabaseLayer, errors are ignored in Mysql ResultSet

[SourceForge.net <no...@so...>]

Patches item #2861075, was opened at 2009-09-17 17:52
Message generated for change (Tracker Item Submitted) made by kkheller
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=462818&aid=2861075&group_id=51305

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: None
Group: Subversion TRUNK
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Kelly Heller (kkheller)
Assigned to: Nobody/Anonymous (nobody)
Summary: DatabaseLayer, errors are ignored in Mysql ResultSet      

Initial Comment:
This patch is intended to demonstrate where I am encountering "silent failures" inside various functions.

This patch demonstrates where I added error-checking and wxFAIL_MSG code in order to help me develop and debug.

This patch is probably not "ready for prime time" so that you would simply apply it to the mainline and include it in the next release.

However, I hope that this patch draws attention to the SILENT FAILURES that can happen.  I would have really appreciated it if some wxASSERT calls or wxFAIL calls existed in this code before I found it.  Therefore, I think other developers might also like for these wxFAIL (or wxASSERT if you choose) calls to be patched into the code one way or another.

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=462818&aid=2861075&group_id=51305