Re: [Wsmanager-devel] Modifications

[Kevin B. <ke...@sb...>]

On Jan 31, 2004, at 6:23 PM, Ka-Hing Cheung wrote:

> gnuarch.org, but as I said, the repository is offline right now. 
> Hopefully it
> will be back soon. My last sync was on 1/22, I can put up a tarball if 
> you
> want. Among some of the new stuff: workspace name on desktop, make
> mouse wrapping configurable, and center mouse on switch workspace.

A tarball would be nice. So would a pointer on how the arch system 
works, as I only know CVS.

> I am attaching the TODO incase you have too much free time.

Hehe, I'll be sure to take a look at it.

>> I've never done this before. What's the generally-accepted format for
>> submitting patches?
>
> If you use arch, tla changes -o <dir>, that will give you a dir with 
> all
> the changes and you can just tar it up. If you are modifying against
> the release, then a diff -u would be fine.

As I only have the v0.5 release source, I did a diff -u on the 
StatusBar Pager plugin directory (to avoid my activeedges changes). 
This file includes 3 changes:

1) A fix where when the number of desktops changes, the pager updates. 
Previously, it wouldn't update unless the pager itself was turned 
on/off, the statusbar menu was turned on/off, or the menu was moved to 
the opposite side of the pager. This fixed one crash, but I think the 
actual bug was the 2nd fix, and this was just one way of causing that 
bug.

2) When a pager cell is created, it's given an associated workspace. 
However, it doesn't retain that workspace. In my tests, modifying the 
desktop count could cause this to crash, presumably by making the cell 
attempt to draw a workspace that has been dealloc'ed. My fix was to 
retain the workspace when setting it, and release it on dealloc. This 
fixed the crash.

3) The pager now transitions when changing workspaces. I know this is 
in the arch, but it was easier to just leave it in here rather than try 
to remove it from the diff.

I've attached the file to the end of the message.

>> Hrm, I just remembered I also fixed the mouse cursor's Y position for
>> active-edges, but there's a patch in the patch-tracker on SF that
>> already does that. I guess I can forget about that one.
>
> Actually I submitted a patch before 0.5.0 was released, but Richard
> feature freezed it already, and he promised me that 0.5.1 will contain
> the fix. So You are probably the 3rd person who fixed the same problem
> :-)

Haha, that's funny :) Hopefully next time I make changes, I don't re-do 
work other people have done.

Thanks for the info,
Kevin