Re: [wsjt-devel] wsprd.c Negative Index in Coarse Estimates Section

[Steven F. <s.j...@ic...>]

Thanks Ryan! I’ve fixed this in our development code. The fix will appear in the next release. 

Steve k9an

> On Apr 26, 2023, at 8:52 AM, Tolboom, Ryan via wsjt-devel <wsj...@li...> wrote:
> 
> Good Morning,
> 
> In the coarse estimates section of the /lib/wsprd/wsprd.c decoder the
> kindex for the time search is negative for the first few iterations.
> It's set on line 1167:
> 
>    kindex=k0+2*k;
> 
> Where k0 is iterating from -10 to 21 and k is iterating over all
> symbols (0 to 161).
> A negative index isn't common in C, but does compile without warning
> and I assume it references something earlier in the 2D ps array.
> If this is an oversight, you could add an additional guard to line 1168:
> 
>    if(( kindex < nffts ) && ( kindex > 0)) {
> 
> I've tried this on my machine and it doesn't seem to affect the
> decodes in any negative way.
> Please let me know if there's something I'm missing.
> 
> 73,
> 
> Ryan Tolboom N2BP
> 
> 
> _______________________________________________
> wsjt-devel mailing list
> wsj...@li...
> https://lists.sourceforge.net/lists/listinfo/wsjt-devel