[Wpg-proxy-development] code review

[Alan M. <a_j...@ya...>]

John,
   
  I am working my way through the code but will probably have a few questions for you.  For now I can see the following immediate questions:
   
  * the code is a bit hard to read in many places owing to formatting - would you have any objection if I ran the classes through GNU indent or similar ? If necessary we can add a svn hook to do that sort of thing automatically.
   
  * to make the licensing a bit clear I'd suggest that you place a license in the root directory and add a template to each Java file (e.g., with a comment, distributed as per shipped license or similar) - I see you have gone for LGPL so we should adopt those conventions perhaps.
   
  * a small detail perhaps but I noticed the use of protected logger members (e.g., in HttpMessage) - I personally feel it would be better to use private (static) logger members in each class since the logger name is based on the java package hierarchy and a logger per class makes things more intuitive (and easier to configure) with the logger configuration.
   
  * finally the classes might benefit from a mild dose of refactoring (e.g., I think that Proxy is a bit too big and has inner classes within where delegation model might be more appropriate etc.) - I could go ahead and model this myself without changing any functionality but don't want to make you too nervous about what I'm doing here - shall we discuss this in more detail ?
   
  all the best,
  Alan.


---------------------------------------------------
You can find my GPG key (a_j...@ya...) at
ETH PGP Keyserver: http://www.tik.ee.ethz.ch/~pgp/
---------------------------------------------------
 		
---------------------------------
Der neue Internet Explorer 7 in deutscher Ausführung ist da!