Add a missing int to particle_ai.h sprint_number param. c99

Brought to you by: jwrdegoede

#2 Add a missing int to particle_ai.h sprint_number param. c99

Milestone: v1.0_(example)

Status: closed

Owner: nobody

Labels: c99 (1)

Priority: 5

Updated: 2023-02-16

Created: 2022-12-23

Creator: Pete Fordham

Private: No

Add a missing int to particle_ai.h sprint_number param. Implicit int is deprecated in C99.
See attached patch.

1 Attachments

worminator-3.0R2.1-c99.patch

Discussion

Pete Fordham - 2022-12-23

Opened as part of this effort:
https://fedoraproject.org/wiki/Toolchain/PortingToModernC

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Hans de Goede - 2023-02-15

status: open --> closed
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Hans de Goede - 2023-02-15

Thanks I had not touched this project in ages, so I've gone ahead and converted the source-code management system to git, and imported all the Fedora patches including this one.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Pete Fordham - 2023-02-16

I'd like to do some further modernization work on the code base. Starting with running it through an autoformatter like clang-format. Would you accept that big of a change?

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Hans de Goede - 2023-02-16

A long time ago I worked on getting various allegro4 games which came with source re-licensed under a proper FOSS license (where necessary) and then porting them to Linux.

worminator was actually one of the first games which I did this for and I pretty much have not touched it since. So if you want to work on it you are more then welcome to.

As for using an auto-formatter, yes that might actually be a good idea in this case. But please make sure you do a single git commit for all the autoformat changes and don't introduce any other changes in that commit.

I think it might be easiest to just give you git push rights on the git repo I created for worminator yesterday.

Shall I add you to the project as a co-maintainer?

Last edit: Hans de Goede 2023-02-16

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Pete Fordham - 2023-02-16

Let me open a PR for what I have so far. You can take a look and then we can go from there.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Log in to post a comment.