Menu

#653 Merge file deletions from preview session

workingwiki
open
None
5
2015-05-14
2015-05-14
Anonymous
No

The cp command that WW uses to merge preview directories into the persistent tree doesn't merge deletions - files that are deleted in the preview directory don't get copied into persistent, but the counterpart in persistent remains undeleted.

Discussion

  • Anonymous

    Anonymous - 2015-05-14

    Surprised not to find this already on the tracker - it's been on my mind for a long time.

     
  • Lee Worden

    Lee Worden - 2015-05-14

    I'm not sure it's about the cp command though - I think I remember switching over to a different design where it just moves the preview directory in place of the persistent one, if there's been no editing that makes it incompatible, or else leaves the persistent data in place and lets the sync process bring it up to date.

    So if that's the design, the problem is that the sync process doesn't re-delete the files, not the cp command.

     
  • Lee Worden

    Lee Worden - 2015-05-14

    And compounding the problem, when you delete a file while previewing, while it does the filesystem deletion in the preview directory, it records the removal as an update to the permanently stored project description, which probably registers as an edit outside the preview session, which marks the preview directory as incompatible, so that it doesn't do the directory replacement when it's saved. :(

     

Anonymous
Anonymous

Add attachments
Cancel