#627 ImportProjectFiles javascript needs update for 1.23

[Lee Worden]

It looks like it's calling some ajax stuff that isn't there any more

[Lee Worden]

I think this is because the upload code (some in WW, some in the MultiUpload extension) needs to be upgraded for MW 1.23 rather than 1.21

[Lee Worden]

I have an error message

unknown function SpecialUpload::ajaxGetExistsWarning

that seems to be blocking me from uploading. But oddly, that message is only in the code that should be run only for MW 1.21 and less. But the wiki's Special:Version page says it's 1.23.5. So I suspect a problem with the way SpecialMultiUpload checks the version number?

... or I don't know what's going on... I added a flagrant typo near that code in SpecialMultiUpload and the wiki isn't crashing. So I think I don't actually know where the code it runs is. I don't know of any documentation of where the source code is, so I hope I can figure it out

[Lee Worden]

OK, at least I've found a copy of MultiUpload that can break the wiki.

If I disable the code that checks $wgVersion and conditionally includes older code for MW 1.21 wikis, let's see if that error goes away

[Lee Worden]

The error persists, even though ajaxGetExistsWarning is only referred to in the files I commented out. Why?

[Lee Worden]

dude

why would

$ wonder@jdserv:/usr/local/workingwiki/WorkingWiki$ grep -r ajaxGetExistsWarning /var/www/html/theobio/worden/extensions/MultiUpload/
/var/www/html/theobio/worden/extensions/MultiUpload/SpecialUpload.1.21.3.php:   public static function ajaxGetExistsWarning( $filename ) {
/var/www/html/theobio/worden/extensions/MultiUpload/resources/upload.js.patched.1.21.3:         'SpecialUpload::ajaxGetExistsWarning',

but

wonder@jdserv:/usr/local/workingwiki/WorkingWiki$ grep -r ajaxGetExistsWarning /var/www/html/theobio/worden/
wonder@jdserv:/usr/local/workingwiki/WorkingWiki$

none of this makes any sense

[Lee Worden]

A: grep -R, not grep -r, to follow symbolic links.

[Lee Worden]

OK, it's not that code in MultiUpload, it's similar code in WW's ext.workingwiki.importprojectfiles.js. Which possibly doesn't use a version check and needs 1.23-compatible code. Commenting out a few lines makes the ajaxGetExistsWarning error stop. There are probably other errors remaining.

This does allow me to upload my file, though, so that's nice.

[Jonathan Dushoff]

Lee:

I don't know how much you've been tracking about a switchover. But I guess
that it's possible that jdserv/yushan is currently not running the same OS
as the "production" nodes.

Had I known you were going to get active, I'd have made sure you were in
the loop.

I think there is a switchover planned for tomorrow, and hopefully everyone
(nodes and head) will be on the same page by the end of the week.

On Tue, Nov 15, 2016 at 4:51 PM, Lee Worden worden@users.sf.net wrote:

OK, it's not that code in MultiUpload, it's similar code in WW's
ext.workingwiki.importprojectfiles.js. Which possibly doesn't use a
version check and needs 1.23-compatible code. Commenting out a few lines
makes the ajaxGetExistsWarning error stop. There are probably other errors
remaining.

This does allow me to upload my file, though, so that's nice.

[bugs:#627] https://sourceforge.net/p/workingwiki/bugs/627/
ImportProjectFiles javascript needs update for 1.23

Status: open
Group: workingwiki
Created: Thu Oct 16, 2014 05:58 PM UTC by Lee Worden
Last Updated: Tue Nov 15, 2016 09:15 PM UTC
Owner: nobody

It looks like it's calling some ajax stuff that isn't there any more

Sent from sourceforge.net because you indicated interest in
https://sourceforge.net/p/workingwiki/bugs/627/

To unsubscribe from further messages, please visit
https://sourceforge.net/auth/subscriptions/

--
McMaster University Department of Biology
http://lalashan.mcmaster.ca/theobio/DushoffLab/
https://twitter.com/jd_mathbio
http://jd-mathbio.blogspot.com/

[Lee Worden]

Thanks for telling me! I don't think this was affected by that.