Disabling default rules
Status: Beta
Brought to you by:
worden
Menu
▾
▴
Doesn't seem to be smoothly implemented.
GNUmakefile is not removed. $(SITE_RESOURCES) is not enabled. Not sure if you consider the latter an issue, or what other issues might be.
Man, it looks like I accidentally split my message again (like the time with Andrei). Sorry.
On 07/31/2013 10:38 AM, Jonathan Dushoff wrote:
These are both issues for sure, that I need to fix.
The split-email thing is weird, but I wouldn't go so far as to expect an
apology for it. I notice that the followup emails don't include your
text as the ticket description. The only thing I can think of is that
since the create-ticket page has both a description field and a comment
field, if you're in a hurry or distracted you might type into the second
one rather than the first. But if you say you're not doing that, then
it's a mystery.
When I click create ticket I only see one field for a text description (as opposed to the title).
Are you logged in at the time?
So I think it's still impossible to disable the WW rules? Or would it work if I manually deleted GNUMakefile? I made an MRE http://lalashan.mcmaster.ca/theobio/projects/index.php/Disable_rules
Yes, I fixed the particular problem by manually clearing the directory, and I guess that's a general solution. I'll leave my MRE, though.
I don't understand the MRE. But I think I understand the bug report: switching off "use WW's supplemental make rules" doesn't delete GNUmakefile, and when you do delete it, $(SITE_RESOURCES) isn't defined.
The loss of $(SITE_RESOURCES) is to be expected, since that variable is defined in the WW makefiles, which are no longer being included. I intended that running without the WW makefiles should be as much like running at your command line as possible, and on the command line SITE_RESOURCES and RESOURCES aren't given to you. OTOH, I can see where it would be useful to give them to you. Or at least to give you RESOURCES and you can define the other one to be $(RESOURCES)/site.
But I'll look at the unremoved makefile problem first.
Have reproduced: doesn't remove GNUmakefile
Am looking at the code and seeing places where it doesn't remove GNUmakefile from the directory. Also looking back at [#324] and [#356], which are the history of this feature.
In [#356] is a note:
Which is odd, because it seems to imply that it was removing the makefile when we turn off the option for a project, or I would have mentioned it, since it's much more obvious than turning it off when we disable the feature for the whole wiki...
The main reason I'm reviewing this stuff is to see if I have code for this in a non-obvious place in WW. I don't see it in the obvious places. But I think I'll just add a delete operation in the set-project-options action, which is what's being called, and if there's partially redundant code somewhere else it's not the worst thing.
GNUmakefile deletion is fixed. The fix won't delete it from projects that already have the make rules turned off, because it does the deletion while unsetting the option. So in those cases you'll need to delete the file manually in the project's directory listing (if you haven't already), or turn the option on and back off.
This leaves the other issue: SITE_RESOURCES, and presumably RESOURCES, isn't defined.
testing what's defined on http://lalashan.mcmaster.ca/theobio/worden/index.php/Test_DIY_makefile_writing. It has RESOURCES but not SITE_RESOURCES when the default makefiles are turned off. This makes sense with the logic I mentioned in a previous comment - SITE_RESOURCES is defined by the default makefiles.
So if it's worth having it provide both RESOURCES and SITE_RESOURCES, I would need to have ProjectEngine provide both as environment variables, rather than having the default makefiles construct SITE_RESOURCES. I think the idea of putting it in the makefile was so that projects could override it by setting it to something else. OTOH they could still do that if it's provided as an environment variable.
Sorry to cause confusion. I presumably meant "not disabled", since otherwise I have no idea what I could have meant. But it looks like this source of confusion may lead you in a positive direction somehow?
?? no, SITE_RESOURCES isn't defined when you turn off the default makefiles, and I think you want it to be defined, is that right?
Well, that's certainly not what I was saying -- I haven't succeeded in
getting rid fo the default makefiles for years, if ever.
Now that you mention it, it sounds like it would be a good idea, though.
JD
Last edit: Lee Worden 2015-04-21
Oh I see, so actually the issue was that SITE_RESOURCES doesn't go away because GNUmakefile doesn't go away. Thanks for clarifying! In that case, I think I'll leave it as is for now, where they both do go away, and see what develops.