Menu

#366 upload link from GPF doesn't preload IPF

workingwiki
closed
None
5
2014-02-06
2013-07-26
Lee Worden
No

In 1.13 when you click 'upload' while looking at a source file in GetProjectFile, you get an ImportProjectFiles form pre-loaded with filename, project name, and destination page. In 1.19+, only the project name is preloaded. Simple enough to fix by adding GET parameters to the link URL.

Related

Bugs: #321

Discussion

  • Lee Worden

    Lee Worden - 2013-08-25

    Also from the Upload button on ManageProject.

     
  • Lee Worden

    Lee Worden - 2014-02-06

    Making some progress on this. An auxiliary question is: should the form be intially collapsed in the usual way if the destination filename and page are preloaded. I feel like it shouldn't.

    Currently the code collapses that if and only if the upload file selector is empty. So I have to think about what the new decision rule should be.

     
    • Lee Worden

      Lee Worden - 2014-02-06

      The thinking about when a row is empty is here.

      I think I can safely change

      • A blank row is one that has a file selector/URL selector, and hasn't been given a file/URL.

      to

      • A blank row is one that has a file selector/URL selector, hasn't been given a file/URL, and the rest of its fields haven't been changed from their default values.

      It's more trouble to implement because the test till be different from MultiUpload to ImportProjectFiles (different fields), but not too bad.

       
  • Lee Worden

    Lee Worden - 2014-02-06
    • assigned_to: Lee Worden
     
  • Lee Worden

    Lee Worden - 2014-02-06

    OK, got the non-collapsing and preloading. I think this is done, pending any bugs surfacing.

     
  • Lee Worden

    Lee Worden - 2014-02-06
    • status: open --> closed
     

Anonymous
Anonymous

Add attachments
Cancel