Menu

#365 MP delete tab is missing

workingwiki
closed
None
5
2013-08-01
2013-07-26
Lee Worden
No

put it back!

Related

Bugs: #321

Discussion

  • Lee Worden

    Lee Worden - 2013-07-30
    • status: open --> closed
    • assigned_to: Lee Worden
     
  • Lee Worden

    Lee Worden - 2013-07-30

    It's missing in the 1.21 test wiki, not in the 1.19 one, that is.

    Experimenting a little, I've found that the code works to insert the delete tab in 1.21, it's that the test for permissions is failing:

        if ($skt->getUser()->isAllowed('delete'))
    

    On further investigation, I've found that I'm seeing the delete tab in the theobio/worden wiki, which is my 1.19 test wiki, because I have the delete right by virtue of being in the Administrators group. This is also what it takes in the 1.21 test wiki, but I didn't make myself an admin there.

    And sure enough, if I add

    $wgGroupPermissions['*']['delete'] = true;
    

    to the config, the tab appears.

    This implies that:

    • The WW code is working
    • It's not doing much good, because nobody but me and maybe Jonathan gets access to it. I'm going to recommend to Jonathan to give delete rights to users, if they want to be able to delete projects. This will also let them delete pages. If we want to uncouple those two rights, I can do that by defining a separate 'delete-project' right in WW.
     
  • Jonathan Dushoff

    Yes, I agree. I think we already did this on the old farm and hopefully you put it somewhere where it will be inherited into the new farm.

     
  • Lee Worden

    Lee Worden - 2013-08-01

    On 08/01/2013 09:03 AM, Jonathan Dushoff wrote:

    Yes, I agree. I think we already did this on the old farm and hopefully
    you put it somewhere where it will be inherited into the new farm.

    I don't remember whether I did. I guess you'll want to compare the
    common- and ww- config scripts to their old-farm counterparts anyway,
    in case there've been changes in the old ones since I created the newer
    ones.

     

Anonymous
Anonymous

Add attachments
Cancel