Menu

#266 warn when closing source-file tag is missing

workingwiki
closed
None
5
2013-05-07
2013-02-20
Lee Worden
No

Doesn't it do this? It should. When you forget a closing </source-file>, it seems it just reads to the end of the next source-file and happily treats it all as one.

It could either stop at the next opening <source-file> and warn, or nest them properly (which might be useful in wikitext source files, though it would probably be a real headache).

Also, if I remember right, it does warn properly when it reaches the end of the page without finding a </source-file>.

Related

Bugs: #419

Discussion

  • Lee Worden

    Lee Worden - 2013-02-20

    Note currently it does handle $$...$$ and the like properly in .wikitext source files, even though those are implemented by replacing them by source-file tags. I think that works while regular source-file tags don't because they're transformed to tags later in the process.

     
  • Lee Worden

    Lee Worden - 2013-02-20

    Working on this. It looks like MW reads from opening tag until next matching closing tag though, so while I can pull source-file content from them as 2 separate tags, the second one won't get displayed on the page, because I let MW figure out where/when to request files to put on the page.

     
  • Lee Worden

    Lee Worden - 2013-02-20

    Done in r976. I also enabled some other warnings in r977, including warning when there are two source-file tags with the same filename, which was the case on the messed-up version of the example page here.

     
  • Lee Worden

    Lee Worden - 2013-02-20
    • status: open --> closed
     
  • Lee Worden

    Lee Worden - 2013-03-07

    Note this bug was opened as a consequence of https://sourceforge.net/p/workingwiki/bugs/265/

     

Anonymous
Anonymous

Add attachments
Cancel