#242 Special:ImportProjectFiles crashes in MW 1.20

[Lee Worden]

Internal error
Jump to: navigation, search

Call to undefined method SkinMonoBook::tooltipAndAccesskey

Backtrace:

#0 /usr/src/WorkingWiki-trunk/SpecialCustomUpload.php(267): Skin->__call('tooltipAndAcces...', Array)
#1 /usr/src/WorkingWiki-trunk/SpecialCustomUpload.php(267): SkinMonoBook->tooltipAndAccesskey('upload')
#2 /usr/src/WorkingWiki-trunk/SpecialImportProjectFiles.php(294): CustomUploadForm->execute()
#3 /usr/src/mediawiki-trunk/includes/SpecialPage.php(611): SpecialImportProjectFiles->execute(NULL)
#4 /usr/src/mediawiki-trunk/includes/SpecialPageFactory.php(494): SpecialPage->run(NULL)
#5 /usr/src/mediawiki-trunk/includes/Wiki.php(290): SpecialPageFactory::executePath(Object(Title), Object(RequestContext))
#6 /usr/src/mediawiki-trunk/includes/Wiki.php(536): MediaWiki->performRequest()
#7 /usr/src/mediawiki-trunk/includes/Wiki.php(446): MediaWiki->main()
#8 /usr/src/mediawiki-trunk/index.php(59): MediaWiki->run()
#9 {main}

Special:ImportProjectFiles is based on an old version of Special:Upload and probably can't be made compatible with current versions of MediaWiki without a major rewrite. However, if we were to abandon old versions of MediaWiki, this could be rewritten easily using newer Special:Upload code, which has been rewritten by MW people to support just this kind of thing.

A consequence of this bug is that WW does not work in even remotely up-to-date MW installations. A problem for building appreciative users, to put it mildly. We need to get up to date.

[Lee Worden]

I wonder if I should mark it as only supported for 1.13-1.17 or so on its home page and the mediawiki.org page, or just leave it.

[Lee Worden]

I think I resolved the 'tooltipAndAccesskey' thing by commenting out a line, but when I click "import" I also get

PHP Fatal error: Class 'MacBinary' not found in /net/theobio-inside/2/yushan/1/local/workingwiki/WorkingWiki/SpecialCustomUpload.php on line 2310

SpecialImportProjectFiles is based on SpecialCustomUpload, which is basically a hacked version of MW 1.13's Special:Upload, and just doesn't work any more. Need to re-engineer based on the current Special:Upload, which is way better suited to it.

[Lee Worden]

created https://sourceforge.net/p/workingwiki/bugs/258 for planning what to do with ImportProjectFiles.

[Lee Worden]

[#299] basically replaces this one.

[Lee Worden]

The new Special:ImportProjectFiles, while still under development, works in MW 1.19+, and so this problem is solved.